Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ feat(rbac): use real ServiceAccount instead of default #519

Merged
merged 1 commit into from
Jun 24, 2024
Merged

⚠️ feat(rbac): use real ServiceAccount instead of default #519

merged 1 commit into from
Jun 24, 2024

Conversation

cwrau
Copy link
Contributor

@cwrau cwrau commented May 7, 2024 •
edited
Loading

Closes #518

@k8s-ci-robot
Copy link
Contributor

Welcome @cwrau!

It looks like this is your first PR to kubernetes-sigs/cluster-api-operator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-operator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @cwrau. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 7, 2024
@netlify Netlify
Copy link

netlify bot commented May 7, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
🔨 Latest commit a4db00b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/6643195988c0dd00082858fc
😎 Deploy Preview https://deploy-preview-519--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cwrau cwrau force-pushed the feat/use-real-serviceaccount branch from 88c8e7d to 168724c Compare May 7, 2024 14:55
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 7, 2024
@cwrau cwrau force-pushed the feat/use-real-serviceaccount branch from 168724c to 7b21533 Compare May 7, 2024 14:58
@cwrau
Copy link
Contributor Author

cwrau commented May 7, 2024

I don't know how I would make the serviceAccountName in the deployment.yaml "generated" like the name in the service_account.yaml, so I just hardcoded it to the value that got generated?

@Fedosin Fedosin changed the title feat(rbac): use real ServiceAccount instead of default ⚠️ feat(rbac): use real ServiceAccount instead of default May 8, 2024
Fedosin
Fedosin reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 8, 2024
@cwrau cwrau force-pushed the feat/use-real-serviceaccount branch from 7b21533 to 8289cd2 Compare May 14, 2024 07:54
@cwrau cwrau force-pushed the feat/use-real-serviceaccount branch from 8289cd2 to a4db00b Compare May 14, 2024 07:57
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 14, 2024
@cwrau
Copy link
Contributor Author

cwrau commented Jun 11, 2024

Heyho, is there something I can do to help this get merged? 😊

alexander-demicev
alexander-demicev approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2024
furkatgofurov7
furkatgofurov7 reviewed Jun 24, 2024
View reviewed changes
config/manager/manager.yaml
@@ -15,6 +15,8 @@ spec:
labels:
control-plane: controller-manager
spec:
serviceAccountName: manager
automountServiceAccountToken: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: is this set to false and best practice, when the default SA is used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand the question correctly, yes, it's best-practice to set this to false when not using a custom serviceAccount to prevent the accidental usage of the default serviceAccount

In general it's best-practice to not use the default serviceAccount anyways

@furkatgofurov7
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f5f14b2b0c0f7450c4f4b41b5755d685ac50892c

@k8s-ci-robot k8s-ci-robot merged commit 628476c into kubernetes-sigs:main Jun 24, 2024
14 checks passed
@cwrau
Copy link
Contributor Author

cwrau commented Jul 4, 2024

Heyho, is there a timeline when this will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fedosin Fedosin Fedosin left review comments

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@alexander-demicev alexander-demicev alexander-demicev approved these changes

@damdo damdo Awaiting requested review from damdo

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@furkatgofurov7 furkatgofurov7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use real ServiceAccount instead of default
5 participants
@cwrau @k8s-ci-robot @furkatgofurov7 @Fedosin @alexander-demicev