馃悰 Don't requeue provider if its spec is invalid #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
Fedosin
changed the title
Currently if provider fails spec validation during preflight checks, we requeue it again with 30 seconds timeout. It doesn't make sense, because the spec still will be invalid and validation will fail again and again. This PR identifies all the places where we don't need to requeue providers, and updates them accordingly.
k8s-ci-robot
added
size/S
|
/retest |
|
Presubmit job failures are not related to this PR but the issue with k8s test-infra itself (same in many other PRs' in different repos currently) and tracked in kubernetes/test-infra#29622 |
|
@furkatgofurov7 thanks! good to know |
|
/retest |
1 similar comment
|
/retest |
k8s-ci-robot
added
the
lgtm
alexander-demicev
approved these changes
May 31, 2023
There was a problem hiding this comment.
Makes sense to me too, we discussed it with @Fedosin earlier this week.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently if provider fails spec validation during preflight checks, we requeue it again with a 30 seconds interval. It doesn't make sense, because the spec still will be invalid and validation will fail again and again.
This PR identifies all places where we don't need to requeue providers and updates them accordingly.