Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generating NSG rules while using shared BYO public IP #6186

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix generating NSG rules while using shared BYO public IP #6186

merged 1 commit into from
May 17, 2024

Conversation

zarvd
Copy link
Contributor

@zarvd zarvd commented May 13, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

bug: When creating LoadBalancer services with a shared BYO public IP, the NSG rules are not generated correctly.

how to reproduce:

  1. create 1 BYO public IP
  2. creating 2 services with service.beta.kubernetes.io/azure-pip-name: {the PIP name}
  3. check NSG rules

This PR would list all services and then filter by IP address instead of using PIP tags when checking for services with a shared PIP.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix generating NSG rules while using shared BYO public IP

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @zarvd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 13, 2024
@zarvd zarvd force-pushed the fix/access-control/shared-ip-with-byo-pip branch from e17b28f to f62b6ab Compare May 14, 2024 00:04
feiskyer
feiskyer reviewed May 14, 2024
View reviewed changes
tests/e2e/network/network_security_group.go
@@ -830,6 +830,153 @@ var _ = Describe("Network security group", Label(utils.TestSuiteLabelNSG), func(
})
})
})

When("creating 2 LoadBalancer services with shared BYO public IP", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks adding a set of new tests

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 14, 2024
@zarvd zarvd force-pushed the fix/access-control/shared-ip-with-byo-pip branch 2 times, most recently from 3fdbe49 to dc8fa09 Compare May 16, 2024 02:19
@zarvd
Copy link
Contributor Author

zarvd commented May 16, 2024

/retest

2 similar comments
@zarvd
Copy link
Contributor Author

zarvd commented May 16, 2024

/retest

@zarvd
Copy link
Contributor Author

zarvd commented May 16, 2024

/retest

@zarvd zarvd force-pushed the fix/access-control/shared-ip-with-byo-pip branch from dc8fa09 to d091723 Compare May 16, 2024 23:08
feiskyer
feiskyer reviewed May 17, 2024
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, zarvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@nilo19
Copy link
Contributor

nilo19 commented May 17, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit c01bb44 into kubernetes-sigs:master May 17, 2024
18 checks passed
@zarvd zarvd deleted the fix/access-control/shared-ip-with-byo-pip branch May 17, 2024 03:24
This was referenced May 17, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@MartinForReal MartinForReal Awaiting requested review from MartinForReal

Assignees

@feiskyer feiskyer

@nilo19 nilo19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zarvd @k8s-ci-robot @nilo19 @feiskyer