Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed import sort order on api_client.py using isort #2100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixed import sort order on api_client.py using isort #2100

wants to merge 2 commits into from
+7 −8

Conversation

anindyahepth
Copy link

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@anindyahepth anindyahepth changed the title fixed import sort order on api_client.py fixed import sort order on api_client.py May 3, 2024
@anindyahepth anindyahepth changed the title fixed import sort order on api_client.py fixed import sort order on api_client.py using isort May 3, 2024
@anindyahepth anindyahepth marked this pull request as draft May 3, 2024 20:02
@anindyahepth anindyahepth marked this pull request as ready for review May 3, 2024 21:35
Anindya Dey and others added 2 commits May 3, 2024 17:38
fixed import sort order on api_client.py
246dd0e 
Signed-off-by: Anindya Dey <[email protected]>
@marcmaliar @JocelynYH
@xyz010 @TheGoop
Fix isort on examples/pytorch (kubeflow#2094)
ff2c17a 
Signed-off-by: Marc Maliar <[email protected]>
Co-authored-by: Jocelyn Huang <[email protected]>
Co-authored-by: Andreas Loutzidis <[email protected]>
Co-authored-by: Akshay Gupta <[email protected]>
Signed-off-by: Anindya Dey <[email protected]>
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anindyahepth
Once this PR has been reviewed and has the lgtm label, please assign johnugeorge for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8945207080

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 35.431%
Totals Coverage Status
Change from base Build 8932297222: 0.05%
Covered Lines: 4380
Relevant Lines: 12362
💛 - Coveralls

andreyvelich
andreyvelich reviewed May 24, 2024
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @anindyahepth 🎉
I left one comment.

sdk/python/kubeflow/training/api_client.py
from kubeflow.training.exceptions import ApiValueError, ApiException
from kubeflow.training.configuration import Configuration
from kubeflow.training.exceptions import ApiException, ApiValueError
from six.moves.urllib.parse import quote
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you remove changes from api_client.py file since this file is generated automatically by CODE_GEN: https://github.com/kubeflow/training-operator/blob/master/hack/python-sdk/gen-sdk.sh#L48.

@andreyvelich
Copy link
Member

cc @marcmaliar @JocelynYH @xyz010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyvelich andreyvelich andreyvelich left review comments

@jinchihe jinchihe Awaiting requested review from jinchihe

@kuizhiqing kuizhiqing Awaiting requested review from kuizhiqing

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anindyahepth @coveralls @andreyvelich @marcmaliar