Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate TFJob examples to TensorFlow 2 #2023

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sandipanpanda
Copy link

What this PR does / why we need it:
Upgrade TensorFlow version in all Dockerfiles to v2

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Part of #2015

@google-oss-prow google-oss-prow bot requested a review from jinchihe March 10, 2024 19:21
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sandipanpanda
Once this PR has been reviewed and has the lgtm label, please assign gaocegege for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandipanpanda Have you tried to build and run these in your local?
I guess that some of these couldn't be buildable or runnable.

@tenzen-y
Copy link
Member

@kubeflow/wg-training-leads Could you approve CI?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8224250888

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 42.885%

Totals Coverage Status
Change from base Build 8214367884: 0.01%
Covered Lines: 3755
Relevant Lines: 8756

💛 - Coveralls

@tenzen-y
Copy link
Member

@sandipanpanda Have you tried to build and run these in your local? I guess that some of these couldn't be buildable or runnable.

Oh, CI proves that all images are buildable.
@sandipanpanda So, can you verify that those images are runnable?

@andreyvelich
Copy link
Member

andreyvelich commented Mar 12, 2024

Thank you for your contribution @sandipanpanda 🎉
@tenzen-y Is right, unfortunately we don't run all TensorFlow examples in on CI to verify them.

I am pretty sure that some TensorFlow APIs that we are using in examples are not compatible with TensorFlow 2.0.

For example, tf.train.AdamOptimizer is tf.keras.optimizers.Adam in TF2: https://www.tensorflow.org/guide/migrate/migrate_tf2

So you might need to run these examples manually to migrate to Tensorflow 2.0 unless we will add them to our CI.

Run the automated script to convert some of TF1.x API usage to
tf.compat.v1.

Signed-off-by: Sandipan Panda <[email protected]>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sandipanpanda
Copy link
Author

@tenzen-y @andreyvelich Thank you for reviewing.

I have started working on migrating TFJob examples to TensorFlow 2 using the migration guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants