Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8 linter for Python files in CI/CD #2022

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sandipanpanda
Copy link

What this PR does / why we need it:
Check the style and quality of python code using flake8 in CI/CD

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes # #1910

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sandipanpanda
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Check the style and quality of python code using flake8 in CI/CD

Signed-off-by: Sandipan Panda <[email protected]>
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @sandipanpanda!

I think the main idea behind this issue #1910 was to add another instruction to the Makefile which will run script from hack directory (e.g. verify-python.sh).
This script will use black and flake8 to check Python code.

So contributors can easily run make fmt-python.
Does it make sense ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants