feat(ws): initial commit for backend #7
Conversation
thesuperzapper
changed the title
ederign
force-pushed
the
nbv2-backend-scaffold
branch
from
f5d5e26
to
b75b06b
Compare
| go 1.22.2 | ||
|
|
||
| require ( | ||
| github.com/julienschmidt/httprouter v1.3.0 |
There was a problem hiding this comment.
Just checking on if this is a currently maintained package, as it last release was in 2019:
https://github.com/julienschmidt/httprouter/releases/tag/v1.3.0
There was a problem hiding this comment.
I'm open to exploring new routers if necessary, but I'm based on this flow chart here: https://www.alexedwards.net/blog/which-go-router-should-i-use
There was a problem hiding this comment.
The package does not have any dependencies! I think it is not very dangerous to use it https://github.com/julienschmidt/httprouter/blob/master/go.mod
ederign
force-pushed
the
nbv2-backend-scaffold
branch
from
b75b06b
to
42ecfcf
Compare
ederign
force-pushed
the
nbv2-backend-scaffold
branch
from
42ecfcf
to
91bc821
Compare
|
@thesuperzapper @jiridanek I've updated my PR as we discussed. I'll open a new issue to discuss the k8 client. |
.gitignore
Outdated
|
|
||
| ## backend | ||
| workspaces/backend/bin |
There was a problem hiding this comment.
maybe create a separate .gitignore file for this in workspaces/backend?
There was a problem hiding this comment.
We had this, but @thesuperzapper asked to remove it on the last review.
There was a problem hiding this comment.
I understand he asked to just remove the last few lines from that (because they would duplicate content of the top level .gitignore)
| .PHONY: help | ||
| help: ## Display this help. | ||
| @awk 'BEGIN {FS = ":.*##"; printf "\nUsage:\n make \033[36m<target>\033[0m\n"} /^[a-zA-Z_0-9-]+:.*?##/ { printf " \033[36m%-15s\033[0m %s\n", $$1, $$2 } /^##@/ { printf "\n\033[1m%s\033[0m\n", substr($$0, 5) } ' $(MAKEFILE_LIST) |
There was a problem hiding this comment.
Just fyi, make version 4.4.1 will natively support a new --print-targets option, which makes this solution unnecessary, if you can have new enough make
Signed-off-by: Eder Ignatowicz <[email protected]>
Signed-off-by: Eder Ignatowicz <[email protected]>
Signed-off-by: Eder Ignatowicz <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek, thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
* feat(ws): initial commit for backend Signed-off-by: Eder Ignatowicz <[email protected]> * Fixing docker build Signed-off-by: Eder Ignatowicz <[email protected]> * Fixing git ignore Signed-off-by: Eder Ignatowicz <[email protected]> --------- Signed-off-by: Eder Ignatowicz <[email protected]> Signed-off-by: Adem Baccara <[email protected]>
Scaffolding of the backend.
In this PR: