ci(ws): add integration test that deploys workspace-controller onto kind cluster #10
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jiridanek, would you mind signing off on the commit? (maybe you need to squash to please DCO bot) |
|
Also, is there a way to see this action running? |
Yeah, click the circle and then Details
|
|
Uh, the link to action run, it disappeared from above! So, here you go https://github.com/jiridanek/notebooks-v2/actions/runs/9284952173/job/25548433943 |
| push: | ||
| branches: [ "main", "notebooks-v2", "v*-branch" ] | ||
| pull_request: | ||
| paths: [ "workspaces/controller/**" ] |
There was a problem hiding this comment.
right, so the action runs on PR only if the files in workspaces/controller change, but not when only the action itself changes!
It's probably a permission issue, but I cannot see the action of the check run here. I checked on your fork. /lgtm |
Signed-off-by: Jiri Daněk <[email protected]>
Signed-off-by: Jiri Daněk <[email protected]>
|
New changes are detected. LGTM label has been removed. |
jiridanek
changed the title
|
As per @thesuperzapper 's suggestion, I switched from k0s to using kind, which made the GHA yaml somewhat shorter. Run can be seen in action at https://github.com/jiridanek/notebooks-v2/actions/runs/9602575963/job/26483718596 |
This is a recreation of https://github.com/kubeflow/kubeflow/blob/master/.github/workflows/nb_controller_intergration_test.yaml.
The main difference is that I don't (yet) do multiarch dockerx build.
Future work
Next step, would be helpful to wait not only for controller readiness, but for some sample CRD instances to have been reconciled by it. Ofc doing multiarch build early would not be bad either.
Having a similar test that uses OpenShift Local to run and podman to build would not go amiss either, in my view. This would force me to investigate the SCC thing https://docs.openshift.com/container-platform/4.15/authentication/managing-security-context-constraints.html