Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a parent flag --log-level to the keadm and make it hidden for debug. #5547

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a parent flag --log-level to the keadm and make it hidden for debug. #5547

wants to merge 1 commit into from

Conversation

luomengY
Copy link
Member

@luomengY luomengY commented Apr 17, 2024 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:
image

Which issue(s) this PR fixes:

Fixes A part of #5317

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@kubeedge-bot kubeedge-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 17, 2024
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign subpathdev after the PR has been reviewed.
You can assign the PR to them by writing /assign @subpathdev in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 17, 2024
@luomengY luomengY force-pushed the log_level branch 3 times, most recently from 3beaee1 to 21a59c9 Compare April 17, 2024 17:29
@kubeedge-bot kubeedge-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2024
@luomengY
Copy link
Member Author

add to v1.17.@Shelley-BaoYue

@Shelley-BaoYue Shelley-BaoYue added this to the v1.17 milestone Apr 18, 2024
@WillardHu WillardHu mentioned this pull request Apr 19, 2024
Open
7 tasks
fisherxu
fisherxu reviewed Apr 20, 2024
View reviewed changes
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add more description, and when the keadm output wil be print in log files or stdout?

keadm/cmd/keadm/app/keadm.go
cmd := cmd.NewKubeedgeCommand()
flags := cmd.Flags()
klog.InitFlags(flagSet)
err := flagSet.Set("v", "0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this default value must required?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this default value must required?

yes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will bring out all klog flags, do we need to hide some?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will bring out all klog flags, do we need to hide some?

There will be no other klog flags introduced here, only "- v, -- v Level number for the log level verbosity"

@luomengY
Copy link
Member Author

Could you please add more description, and when the keadm output wil be print in log files or stdout?

bc1faf9b865f04e5d82ae61f3966586

@luomengY
Copy link
Member Author

PTAL,thanks @WillardHu @fisherxu

@WillardHu
Copy link
Collaborator

WillardHu commented Apr 24, 2024 •
edited

Please modify the description Which issue(s) this PR fixes:

@luomengY
Copy link
Member Author

Please the description Which issue(s) this PR fixes:

ok

@WillardHu
Copy link
Collaborator

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillardHu WillardHu WillardHu left review comments

@fisherxu fisherxu fisherxu left review comments

@Shelley-BaoYue Shelley-BaoYue Awaiting requested review from Shelley-BaoYue

Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@luomengY @kubeedge-bot @WillardHu @fisherxu @Shelley-BaoYue