Proposal: When the edge node goes offline, add pod restart and status query functions for the edge node #5535
Conversation
kubeedge-bot
added
the
kind/feature
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
size/L
luomengY
force-pushed
the
edgepod_restart_get_proposal
branch
2 times, most recently
from
67abf66
to
e52b0ca
Compare
kubeedge-bot
removed
the
kind/feature
| status: implementable | ||
| --- | ||
|
|
||
| # When the edge node goes offline, add pod restart and status query functions for the edge node |
There was a problem hiding this comment.
I think it’s inappropriate to use a long sentence as a feature title. Can you simplify it? Maybe it can be called “Pod offline status query and restart”， for reference only
|
|
||
| ## Motivation | ||
|
|
||
| When the edge node is offline, it is not possible to query the status of the edge node pod and restart the pod of the edge node through kubectl in the cloud. This feature provides support for querying and restarting the pod status of the edge node. |
There was a problem hiding this comment.
The scene in the last sentence is not very clear. Maybe it can be changed to "This feature provides support for querying and restarting the pod status from edge with offline edge node " . You can check whether this statement is correct
There was a problem hiding this comment.
The scene in the last sentence is not very clear. Maybe it can be changed to "This feature provides support for querying and restarting the pod status from edge with offline edge node " . You can check whether this statement is correct
In fact, pods can be queried and restarted both online and offline.
luomengY
force-pushed
the
edgepod_restart_get_proposal
branch
2 times, most recently
from
3438c55
to
7d9d9fa
Compare
| ### Goals | ||
|
|
||
| - By using the `keadm get pod [flags]` command on edge nodes, the status of pod can be queried. | ||
| - By using the `keadm restart pod [flags]` command on edge nodes, pod can be restarted. |
There was a problem hiding this comment.
My personal opinion. keadm get and restart belong to the same category of operations. I think it's more appropriate to unify them under keadm subcommand, like keadm xxx get/restart. Also it would make it easier for future expanision.
cc @WillardHu @fisherxu @wbc6080
There was a problem hiding this comment.
I think it may not be very suitable to include extended functions in keadm in the future, such as describe/logs/exec. Future extensions may not only be for pod resources, such as device, etc. So can we try to maintain some command styles of kubectl in the upstream k8s as much as possible?
luomengY
force-pushed
the
edgepod_restart_get_proposal
branch
2 times, most recently
from
1df65c1
to
0ea50a0
Compare
… query functions for the edge node Signed-off-by: luomengY <[email protected]>
luomengY
force-pushed
the
edgepod_restart_get_proposal
branch
from
0ea50a0
to
2b35cf6
Compare
|
add it to v1.17. @Shelley-BaoYue |
… query functions for the edge node
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #5504
Special notes for your reviewer:
Does this PR introduce a user-facing change?: