Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FeatureGate support for keadm join command #5508

Closed
wants to merge 0 commits into from

Conversation

micplus
Copy link
Contributor

@micplus micplus commented Apr 4, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:
As mentioned in #5507, we can add featuregates flag to keadm join command. Then users can enable new alpha features when setting up edge nodes by keadm.

Which issue(s) this PR fixes:

Fixes #5507

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@micplus micplus force-pushed the feat/keadm-featuregate branch 3 times, most recently from 4163e71 to 1634f24 Compare April 4, 2024 07:39
@micplus
Copy link
Contributor Author

micplus commented Apr 4, 2024

@Shelley-BaoYue

@Shelley-BaoYue Shelley-BaoYue added this to the v1.17 milestone Apr 10, 2024
@fisherxu fisherxu closed this Apr 10, 2024
@fisherxu fisherxu reopened this Apr 10, 2024
@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 10, 2024
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/assign @WillardHu @Shelley-BaoYue

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
@Shelley-BaoYue
Copy link
Collaborator

/approve /assign @WillardHu @Shelley-BaoYue

I have a different opinion. --set will be supported in next release, then we can use --set to configure featuregates. Does this pr still need to be merged in this release?

@kubeedge-bot kubeedge-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2024
@kubeedge-bot
Copy link
Collaborator

@micplus: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fisherxu
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add FeatureGate support for keadm join command
5 participants