Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropped edges during a coalesce operation #64

Merged
merged 10 commits into from
Apr 21, 2018
Merged

Conversation

kuanb
Copy link
Owner

@kuanb kuanb commented Apr 21, 2018

Fixes #57

Conveniently leverages the new simplify operation added to resolve lost edges and hanging nodes issue.

Example of LA (which was not working before) working now:
image

@codecov
Copy link

codecov bot commented Apr 21, 2018

Codecov Report

Merging #64 into master will increase coverage by 0.17%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   90.28%   90.45%   +0.17%     
==========================================
  Files          12       12              
  Lines         741      744       +3     
==========================================
+ Hits          669      673       +4     
+ Misses         72       71       -1
Impacted Files Coverage Δ
peartree/toolkit.py 96.4% <80%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7079a6b...2b780b8. Read the comment docs.

@kuanb kuanb merged commit cb2debb into master Apr 21, 2018
@kuanb kuanb deleted the kuanb-fix-coalesce branch April 21, 2018 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coalesce losing edges on Los Angeles GTFS
1 participant