Fix compile on Alpine Linux when using fortified headers #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes obsolete compatibility code that was causing
compilation errors on Alpine Linux when the fortify-headers package is
installed. In short, the readlink, symlink and realpath compatibility
functions in src/lib/libast/comp don't work with Alpine Linux's
fortified headers. None of these functions are necessary to compile on
current operating systems (tested on Linux with glibc and musl,
{Free,Net,Open,DragonFly}BSD, illumos, Haiku and Cygwin) so these can be
safely deleted. Additionally, some spurious macro hackery relating to
strlcpy, strlcat and networking functions used in libcmd uname has also
been deleted. (The patch to univlib.h is taken from
ksh93#743 (comment).)
Co-authored-by: xorrvin <[email protected]>
|
After this patch ksh compiles again on Alpine with fortified headers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes obsolete compatibility code that was causing compilation errors on Alpine Linux when the fortify-headers package is installed. In short, the
readlink,symlinkandrealpathcompatibility functions in src/lib/libast/comp don't work with Alpine Linux's fortified headers. None of these functions are necessary to compile on current operating systems (tested on Linux with glibc and musl, {Free,Net,Open,DragonFly}BSD, illumos, Haiku and Cygwin) so these can be safely deleted. Additionally, some spurious macro hackery relating topoll,strlcpy,strlcatand networking functions used in libcmdunamehas also been deleted. (The patch to univlib.h is taken from #743 (comment).)Fixes #743