Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a troff formatting error in the manpage. #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix a troff formatting error in the manpage. #5

wants to merge 1 commit into from

Conversation

jghub
Copy link
Member

@jghub jghub commented Mar 9, 2020

fixes a trivial troff formatting error in the manpage which results in erroneous display of the default value of TIMEFORMAT with man ksh.

@jghub jghub added the documentation Improvements or additions to documentation label Mar 9, 2020
@jghub jghub requested review from jelmd and marcastel March 9, 2020 12:27
marcastel
marcastel approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@marcastel marcastel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks :-)

@jelmd
Copy link
Member

jelmd commented Mar 9, 2020

OK wrt.

ksh/src/cmd/ksh93/data/msg.c

Line 213 in e7f2542

const char e_timeformat[] = "\nreal\t%2lR\nuser\t%2lU\nsys\t%2lS";

jelmd
jelmd approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@jelmd jelmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see discussion

@dannyweldon
Copy link
Member

Should we be submitting these directly to the master branch though?

@jelmd
Copy link
Member

jelmd commented Mar 10, 2020

Yes.

JohnoKing added a commit to JohnoKing/ksh that referenced this pull request Jun 25, 2020
@JohnoKing
Fix some errors in the documentation and other minor issues
7d40719 
Somewhat notable changes in this commit:
- The 'set +r' bugfix (re: 74b4162) is now documented in the
  changelog.
- Missing options have been added to the synopsis section of the
  ksh man page.
- The minor formatting fix from ksh-community/ksh#5 has been
  applied to the ksh man page.
- A few fixes from att/ast@5e747cfb have been applied to the ksh
  man page.
- The man page fixes from att#353 have been applied, being:
  - An addition to document the behavior of 'set -H'.
  - A fix for the cd section appending rksh93.
  - A fix for some options being indented too far.
  - Removal of a duplicate section documenting '-D'.
  - Reordering the options for 'set' in alphabetical order.
  - A minor fix for the documentation of 'ksh -i'.
- One minor fix from Red Hat has been applied to the ksh man page:
  https://git.centos.org/rpms/ksh/blob/c8/f/SOURCES/ksh-20120801-manfix4.patch
@JohnoKing JohnoKing mentioned this pull request Jun 25, 2020
Merged
JohnoKing added a commit to JohnoKing/ksh that referenced this pull request Jun 25, 2020
@JohnoKing
Fix some errors in the documentation and other minor issues
9a3139d 
Somewhat notable changes in this commit:
- The 'set +r' bugfix (re: 74b4162) is now documented in the
  changelog.
- Missing options have been added to the synopsis section of the
  ksh man page.
- The minor formatting fix from ksh-community/ksh#5 has been
  applied to the ksh man page.
- A few fixes from att/ast@5e747cfb have been applied to the ksh
  man page.
- The man page fixes from att#353 have been applied, being:
  - An addition to document the behavior of 'set -H'.
  - A fix for the cd section appending rksh93.
  - A fix for some options being indented too far.
  - Removal of a duplicate section documenting '-D'.
  - Reordering the options for 'set' in alphabetical order.
  - A minor fix for the documentation of 'ksh -i'.
McDutchie added a commit to ksh93/ksh that referenced this pull request Jun 25, 2020
@McDutchie
Fix some errors in the documentation and other minor issues (#42)
ed41611 
Somewhat notable changes in this commit:
- The 'set +r' bugfix (re: 74b4162) is now documented in the
  changelog.
- Missing options have been added to the synopsis section of the
  ksh man page.
- The minor formatting fix from ksh-community/ksh#5
  has been applied to the ksh man page.
- A few fixes from att@5e747cfb
  have been applied to the ksh man page.
- The man page fixes from att#353
  have been applied, being:
  - An addition to document the behavior of 'set -H'.
  - A fix for the cd section appending rksh93.
  - A fix for some options being indented too far.
  - Removal of a duplicate section documenting '-D'.
  - Reordering the options for 'set' in alphabetical order.
  - A minor fix for the documentation of 'ksh -i'.
McDutchie pushed a commit to ksh93/ksh that referenced this pull request Jun 25, 2020
@JohnoKing @McDutchie
Fix some errors in the documentation and other minor issues (#42)
d41ec67 
Somewhat notable changes in this commit:
- The 'set +r' bugfix (re: 74b4162) is now documented in the
  changelog.
- Missing options have been added to the synopsis section of the
  ksh man page.
- The minor formatting fix from ksh-community/ksh#5
  has been applied to the ksh man page.
- A few fixes from att@5e747cfb
  have been applied to the ksh man page.
- The man page fixes from att#353
  have been applied, being:
  - An addition to document the behavior of 'set -H'.
  - A fix for the cd section appending rksh93.
  - A fix for some options being indented too far.
  - Removal of a duplicate section documenting '-D'.
  - Reordering the options for 'set' in alphabetical order.
  - A minor fix for the documentation of 'ksh -i'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelmd jelmd jelmd approved these changes

@marcastel marcastel marcastel approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jghub @jelmd @dannyweldon @marcastel