changed k8s api endpoints from v1beta1 to v1 in order to work on k8s>… #740
+21
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doagl
requested review from
thomastaylor312,
bacongobbler,
kflansburg and
technosophos
as code owners
|
Hi there @doagl, thanks for the contribution! So currently Krustlet is pretty much unmaintained. https://github.com/containerd/runwasi has become the more recommended way to enable running wasm inside of k8s! |
|
@thomastaylor312 would it make sense to add a note about the state of this project and link to https://github.com/containerd/runwasi in the README? |
|
A note about the projects status sound's good. The PR might be worth pulling nonetheless, because then krustlet at least works with v1 k8s APIs. |
|
Yeah, makes sense. Could you please sign your commit off for DCO real quick? |
…1.21 Signed-off-by: Stefan Ströbl <[email protected]>
Signed-off-by: Stefan Ströbl <[email protected]>
doagl
force-pushed
the
feature/run-krustlet-with-newest-k8s
branch
from
a9784bf
to
82a46ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that krustlet doesn't start on newer kubernetes versions (>1.21), due to deprecated api endpoints (to be more specific: v1beta1 is EOL for CertificateSigningRequest on k8s 1.22, see https://kubernetes.io/docs/reference/using-api/deprecation-guide/#certificatesigningrequest-v122).
With these changes i was able to deploy the greet-pod on krustlet with a local k3d and kubernetes 1.25.
Thanks for your cool tool!