Validate config properties

[yunkunrao]

This is related with #589

Signed-off-by: rao yunkun [email protected]

[bacongobbler]

Thanks @yunkunrao. I appreciate that you added tests to accompany this change as well. LGTM!

[thomastaylor312]

@yunkunrao Looks like your tests are expecting a path that isn't there on the runner. You might need to generate a kubeconfig for the test to use

[yunkunrao]

I have refactored this PR and add a public method is_valid() which is dedicated for config validatiion. If have any suggestions, please feel free to let me know. Thanks.

[bacongobbler]

Thanks @yunkunrao. It looks like this is failing the DCO sign-off - one of the reverted commits is missing the "Signed-off-by" header required by the DCO. See https://github.com/krustlet/krustlet/pull/683/checks?check_run_id=3816534329 for more details

I don't see any reason why the windows e2e tests failed. I'll try restarting those and see what happens. Try rebasing your commits onto main?

[yunkunrao]

Thanks @yunkunrao. It looks like this is failing the DCO sign-off - one of the reverted commits is missing the "Signed-off-by" header required by the DCO. See https://github.com/krustlet/krustlet/pull/683/checks?check_run_id=3816534329 for more details

I don't see any reason why the windows e2e tests failed. I'll try restarting those and see what happens. Try rebasing your commits onto main?

Got it. I have squashed commits to a single one.