Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable error throw #226

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thethanghn
Copy link

No description provided.

@bluepnume
Copy link
Collaborator

Can you remove any changes to dist, yarn.lock, etc. and just include code changes?

Also, can you please make this guarded by a global, like if (__ZOID__.ALLOW_PARENT_CHILD_VERSION_MISMATCH)

@bluepnume
Copy link
Collaborator

I'm thinking we should still validate the major version no matter what. This may require some additional thought...

The problem I want to avoid here is compatibility issues between parent and child, without a clear error message. This is a really easy situation to end up in if zoid adds a new parameter to the interface between parent and child...

@thethanghn
Copy link
Author

thethanghn commented Sep 3, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants