initial attempt at before and after hooks

[dondod]

This PR is an attempt to fix #2792. The before hook works, but I'm having trouble figuring out an approach for the after hook. I have a failing test for the after hook. In the current code, only the top-level after hook runs, so the assertion fails in that hook. It seems that I can either get all the after hooks to run, but run more than once (like afterEach) or I can get only one to run at all.

Any ideas on how to get each after hook to run exactly once, and starting with the deepest-nested hook?

[Kantis]

@dondod I adjusted your implementation slightly. Check my commit and see if it aligns with your interpretation of the issue.

[Kantis]

@dondod api_check is failing, since the ABI doesn't match the dump. Please run ./gradlew apiDump and commit the updated .api file(s).

See https://github.com/kotlin/binary-compatibility-validator/ for more info

[dondod]

Thanks @Kantis - your changes do work. So simple too..

I'll run the apiDump task and commit.

[dondod]

Hi @Kantis - I don't see what is causing the test_linux jvmTest failure. Anything I need to change?

[Kantis]

What I think is happening is that one of the tests is using a Kotest extension that has been built using an older version of Kotest. That version of Kotest's TestListener did not include the newly added BeforeListener, and thus it hasn't inherited the default implementation for that method.

Either we need to push this feature to 6.0 and do a breaking change and update all extensions (including third-party ones), or we must introduce a new interface and deprecate the old one. @sksamuel are there other ways to fix this?