Ensure absolute imports #2789
Ensure absolute imports #2789
Conversation
kornia/augmentation/__init__.py
Outdated
| from kornia.augmentation._2d.base import AugmentationBase2D, RigidAffineAugmentationBase2D | ||
| from kornia.augmentation import auto | ||
| from kornia.augmentation import container | ||
| from kornia.augmentation._2d import CenterCrop |
There was a problem hiding this comment.
Maybe here makes sense wildcards and inside the sub module we add what to be imported by the all variable
There was a problem hiding this comment.
i don't understand what do you mean
kornia/feature/__init__.py
Outdated
| from .sold2 import SOLD2, SOLD2_detector | ||
| from .sosnet import SOSNet | ||
| from .tfeat import TFeat | ||
| from kornia.feature.affine_shape import LAFAffineShapeEstimator |
There was a problem hiding this comment.
Maybe same here with wildcards
johnnv1
force-pushed
the
feat/force-absolute-imports
branch
from
16d4321
to
9f1001e
Compare
We should manually review each one for it, or do you know how to automate it? |
| @@ -5,12 +5,11 @@ | |||
| import torch | |||
|
|
|||
| from kornia.core import stack | |||
| from kornia.geometry.calibration.distort import distort_points, tilt_projection | |||
| from kornia.geometry.linalg import transform_points | |||
| from kornia.geometry.transform import remap | |||
There was a problem hiding this comment.
@johnnv1 just as random example, this import is not full absolute to where it’s actually implemented. I’m pretty sure there way more in code base
There was a problem hiding this comment.
got it, needs to review/check each one
This patch bans relative imports, and moves all our relative imports to absolute imports using ruff
based on https://docs.astral.sh/ruff/settings/#lint_flake8-tidy-imports_ban-relative-imports
To reproduce:
tool.ruff.lint.flake8-tidy-importsrule to ban relative importsruff run ./ --fix --unsafe-fixesTo be merged after #2788