Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add PR benchmark #2778

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

CI: Add PR benchmark #2778

wants to merge 4 commits into from

Conversation

johnnv1
Copy link
Member

@johnnv1 johnnv1 commented Feb 3, 2024

Introduces a CI for benchmarking (#2777) on PRs, and comparing its base (main branch) against the HEAD (PR last commit)

Should be fine to go after I add fetch-depth on kornia/workflows env and release the 1.5.3. Plus the #2777 should go first

@johnnv1 johnnv1 added the CI ⚙️ Continuous Integration label Feb 3, 2024
@johnnv1
Copy link
Member Author

johnnv1 commented Mar 29, 2024

I added a better suite of benchs in #2853
So makes more sense to try to set it now

pytest ./ -vvv --benchmark-json ${{ env.HEAD_JSON }}

- name: Comment benchmark result
uses: benchmark-action/github-action-benchmark@v1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one didn't publish in the PR as a comment, it relies on gh pages to have a history -- what we need here is something to check on PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI ⚙️ Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant