Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Support for raw tensors in CameraModel #2731

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cjpurackal
Copy link
Member

Changes

Fixes #2708

TODO:

  • fix mypy

Type of change

  • 馃摎 Documentation Update
  • 馃И Tests Cases
  • 馃悶 Bug fix (non-breaking change which fixes an issue)
  • 馃敩 New feature (non-breaking change which adds functionality)
  • 馃毃 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 馃摑 This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change?

@cjpurackal cjpurackal marked this pull request as draft January 14, 2024 17:16
@cjpurackal
Copy link
Member Author

This PR treats the camera API to be unbatched i.e the image_sizes and camera parameters are expected to be unbatched. If it should be batched, we need to address how that will behave. (maybe in a different PR/Issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support raw Tensor in CameraModel
1 participant