better flatpak support #11833
better flatpak support #11833
Conversation
frontend/device/sdl/device.lua
Outdated
| local Flatpak = Device:extend{ | ||
| model = "Flatpak", | ||
| isDesktop = yes, | ||
| canRestart = no, |
There was a problem hiding this comment.
The flatpak version can't restart?
There was a problem hiding this comment.
my bad
it actually can with flathub/rocks.koreader.KOReader#43
There was a problem hiding this comment.
That code, the handling of $@/$ARGS does not look right to me:
▸ set -- 1 2 3
▸ echo "${#@}"
3
▸ ARGS="$@"
▸ echo "$ARGS"
1 2 3
▸ printf '“%s”\n' "$ARGS"
“1 2 3”
▸ ARGS=""
▸ printf '“%s”\n' "$ARGS"
“”There was a problem hiding this comment.
It works nonetheless :).
Feel free to suggest something better.
| local Flatpak = Device:extend{ | ||
| model = "Flatpak", | ||
| isDesktop = yes, | ||
| canExternalDictLookup = no, |
There was a problem hiding this comment.
What would be the Flatpak way of doing that btw, if you know?
There was a problem hiding this comment.
--filesystem=host-os lets you access /usr binaries linked somewhere within the app sandbox. They're not on the PATH so it requires another method of probing dicts.
Also, the kind of people that uses KOReader from a flatpak might have goldendict sandboxed too, so it won't work at all.
I'm mostly happy disabling 3rd party dicts. xdg-open works fine to open links in the browser, so hey :)
* ship metadata with generic linux binaries * append release version & data at build time
Add a flavor to represent flatpak limitations (No OTA updates. Cannot restart, reboot, poweroff... )
Include appstream metadata in generic linux packages. Related to flathub/rocks.koreader.KOReader#42
Add version and release data to appstream metadata at build time for appimage/linux flavors.
Maybe @benoit-pierre could come up with a better
make|sedfoo? Thanks!This change is