Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Kindle Scribe hardware rotation #11809

Conversation

mergen3107
Copy link
Contributor

@mergen3107 mergen3107 commented May 12, 2024

Trying to re-implement fixes discussed in #11269 (comment)

Work in Progress. I mainly created this PR to be able to quickly show and ask about steps I tried.

Maybe this PR will become a good one in future?


This change is Reviewable

@mergen3107
Copy link
Contributor Author

Didn't achieve much progress today. To be continued :D

@mergen3107
Copy link
Contributor Author

mergen3107 commented May 13, 2024

I played around yesterday with Kindle Scribe Init and KindleTouch:Exit(), but I found out that Generic Device Init is in the way.

My goal with these optimization is to force Kindle SW and HW rotation to canonical upright Portrait ("0" in SW, "3" in HW) upon every cold start. This will make sure that the swipe directions are setup correctly each time.

However, Generic Device Exit saved the last rotation upon exit or restart which Generic Device Init then restore to upon fresh start or restart.

  1. Is there a way to let Generic Device Init know that this is a restart and not a fresh start? This has worked great to pass through between Generic Device Exit and KindleTouch Exit, but I couldn't make it work between Generic Exit and Generic Init.

  2. If so, may I guard that code with "if restart" so that it doesn't restore rotation if it's a fresh start?

If the answer is no and you guys wouldn't like to change Device Init (because it is common for all devices), then that's probably OK. I am happy as long as my end result doesn't have touch and UI rotations misaligned.

Thanks!

@mergen3107
Copy link
Contributor Author

(Commits aren't up to date with my experiments yet, so please don't review yet)

@mergen3107
Copy link
Contributor Author

Same as here:
#11265 (comment)

@mergen3107 mergen3107 closed this Jun 5, 2024
@Frenzie
Copy link
Member

Frenzie commented Jun 5, 2024

Any relation to koreader/koreader-base#1719?

@mergen3107
Copy link
Contributor Author

@Frenzie
Sort of :D I close that one too, because I got a Kindle Scribe case that enforces U orientation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants