-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Monetization #932
base: main
Are you sure you want to change the base?
Conversation
forgot to implement the premium required action interaction response :') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the pr :)
i've looked at the code for common
and gateway
for now, i will look at rest
and core
later.
would be good to also add the error codes documented in this pr: discord/discord-api-docs#6499
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking at core
will follow tmrw
also some tests fail, now that |
With an empty array or should I write mock data? |
empty should be enough, do as you see fit |
Co-authored-by: Luca Kellermann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first part of reviewing core
, i still have some files left to review
core/src/commonMain/kotlin/behavior/interaction/ActionInteractionBehavior.kt
Outdated
Show resolved
Hide resolved
core/src/commonMain/kotlin/behavior/interaction/ActionInteractionBehavior.kt
Outdated
Show resolved
Hide resolved
core/src/commonMain/kotlin/exception/EntityNotFoundException.kt
Outdated
Show resolved
Hide resolved
core/src/commonMain/kotlin/gateway/handler/EntitlementEventHandler.kt
Outdated
Show resolved
Hide resolved
core/src/commonMain/kotlin/gateway/handler/EntitlementEventHandler.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost done reviewing (sorry that it takes this long and for all the comments 😅)
common/src/commonTest/resources/json/interaction/slash_command_permissions_update.json
Outdated
Show resolved
Hide resolved
core/src/commonMain/kotlin/gateway/handler/EntitlementEventHandler.kt
Outdated
Show resolved
Hide resolved
awaiting replies before committing my other changes
Docs: https://discord.com/developers/docs/monetization/overview
I've tested this code to the best of my ability, i.e., only the pagination for the list entitlements endpoint is untested and I wasn't able to get entitlement events to work, they might only work with real subscriptions 🤷🏼