Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: add nri remove #2046

Merged
merged 1 commit into from
May 21, 2024

Conversation

kangclzjc
Copy link
Member

Ⅰ. Describe what this PR does

Add NRI RemovePodSandbox event handler into koordlet hook. It's part of the #1974. Resctrl runtime hook will leverage this to cleanup the resctrl group.

Ⅱ. Does this pull request fix one issue?

#1831

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@kangclzjc
Copy link
Member Author

/assign @saintube, PTAL.

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.73%. Comparing base (afa430a) to head (1d5bd58).
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/koordlet/runtimehooks/protocol/pod_context.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2046      +/-   ##
==========================================
- Coverage   68.75%   68.73%   -0.02%     
==========================================
  Files         423      423              
  Lines       39246    39263      +17     
==========================================
+ Hits        26985    26989       +4     
- Misses       9928     9938      +10     
- Partials     2333     2336       +3     
Flag Coverage Δ
unittests 68.73% <88.23%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koordinator-bot koordinator-bot bot added size/L and removed size/M labels May 16, 2024
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Zhang Kang <[email protected]>
@kangclzjc
Copy link
Member Author

@jasonliu747 PTAL

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, saintube

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 44d8d1b into koordinator-sh:main May 21, 2024
20 checks passed
@saintube saintube added this to the v1.5 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants