Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: migrate to 1.28.7 #2038

Merged

Conversation

ZiMengSheng
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 47.94953% with 165 lines in your changes are missing coverage. Please review.

Project coverage is 68.57%. Comparing base (877d8fb) to head (7883bea).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/scheduler/frameworkext/scheduler_adapter.go 0.00% 41 Missing ⚠️
pkg/webhook/elasticquota/validating/webhooks.go 0.00% 11 Missing ⚠️
.../frameworkext/eventhandlers/reservation_handler.go 50.00% 4 Missing and 5 partials ⚠️
...heduler/frameworkext/framework_extender_factory.go 0.00% 9 Missing ⚠️
pkg/webhook/elasticquota/mutating/webhooks.go 0.00% 7 Missing ⚠️
pkg/webhook/pod/mutating/webhooks.go 0.00% 7 Missing ⚠️
pkg/webhook/pod/validating/webhooks.go 0.00% 7 Missing ⚠️
pkg/koordlet/qosmanager/framework/context.go 0.00% 5 Missing ⚠️
pkg/webhook/cm/validating/webhooks.go 0.00% 5 Missing ⚠️
pkg/webhook/node/mutating/webhooks.go 0.00% 5 Missing ⚠️
... and 25 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2038      +/-   ##
==========================================
- Coverage   68.74%   68.57%   -0.18%     
==========================================
  Files         423      430       +7     
  Lines       39199    39311     +112     
==========================================
+ Hits        26949    26956       +7     
- Misses       9917    10021     +104     
- Partials     2333     2334       +1     
Flag Coverage Δ
unittests 68.57% <47.94%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZiMengSheng ZiMengSheng force-pushed the migrate_1.28_upstream branch 3 times, most recently from ea00f00 to affb081 Compare May 8, 2024 10:19
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the upgradation of the client-go and Docker image, some compatible issues should be noticed for the koordlet and koord-manager.

docker/koordlet.dockerfile Show resolved Hide resolved
cmd/koord-manager/main.go Outdated Show resolved Hide resolved
@ZiMengSheng ZiMengSheng force-pushed the migrate_1.28_upstream branch 4 times, most recently from 8f60386 to eea86de Compare May 9, 2024 10:03
.github/workflows/e2e-k8s-1.28.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e-k8s-1.28.yaml Outdated Show resolved Hide resolved
@ZiMengSheng ZiMengSheng force-pushed the migrate_1.28_upstream branch 4 times, most recently from bc2d99b to efb41dc Compare May 10, 2024 02:45
Signed-off-by: wangjianyu.wjy <[email protected]>
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit b6e7bc0 into koordinator-sh:main May 20, 2024
21 checks passed
@saintube saintube added this to the v1.5 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants