Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: support numa topology policy on pod #1939

Merged
merged 1 commit into from
May 20, 2024

Conversation

KunWuLuan
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

to #1912

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@KunWuLuan KunWuLuan changed the title support numa topology policy on pod WIP: support numa topology policy on pod Mar 6, 2024
@KunWuLuan KunWuLuan force-pushed the feat/pod-numa-policy branch 2 times, most recently from 6997a04 to dd70b1a Compare March 6, 2024 07:24
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 78.43137% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 68.78%. Comparing base (afa430a) to head (a1f2fa6).

Files Patch % Lines
.../scheduler/frameworkext/topologymanager/manager.go 0.00% 7 Missing ⚠️
pkg/scheduler/plugins/nodenumaresource/plugin.go 66.66% 3 Missing and 3 partials ⚠️
...g/scheduler/frameworkext/topologymanager/policy.go 73.33% 2 Missing and 2 partials ⚠️
...eduler/plugins/nodenumaresource/node_allocation.go 90.62% 2 Missing and 1 partial ⚠️
pkg/scheduler/frameworkext/framework_extender.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1939      +/-   ##
==========================================
+ Coverage   68.75%   68.78%   +0.02%     
==========================================
  Files         423      423              
  Lines       39246    39319      +73     
==========================================
+ Hits        26985    27046      +61     
- Misses       9928     9934       +6     
- Partials     2333     2339       +6     
Flag Coverage Δ
unittests 68.78% <78.43%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koordinator-bot koordinator-bot bot added size/XL and removed size/L labels Mar 6, 2024
@KunWuLuan KunWuLuan force-pushed the feat/pod-numa-policy branch 2 times, most recently from eaddd15 to be831a8 Compare March 6, 2024 11:20
@koordinator-bot koordinator-bot bot added size/L and removed size/XL labels Mar 6, 2024
@KunWuLuan KunWuLuan force-pushed the feat/pod-numa-policy branch 3 times, most recently from 6a547d1 to f923b9a Compare March 6, 2024 12:03
@KunWuLuan KunWuLuan changed the title WIP: support numa topology policy on pod support numa topology policy on pod Mar 6, 2024
@saintube saintube changed the title support numa topology policy on pod scheduler: support numa topology policy on pod Mar 7, 2024
apis/extension/numa_aware.go Outdated Show resolved Hide resolved
apis/extension/numa_aware.go Outdated Show resolved Hide resolved
apis/extension/numa_aware.go Outdated Show resolved Hide resolved
apis/extension/numa_aware.go Outdated Show resolved Hide resolved
@KunWuLuan KunWuLuan force-pushed the feat/pod-numa-policy branch 4 times, most recently from 23cecc8 to a36aa27 Compare April 25, 2024 03:03
@KunWuLuan KunWuLuan force-pushed the feat/pod-numa-policy branch 2 times, most recently from b799330 to 4ea9576 Compare April 25, 2024 03:38
@ZiMengSheng
Copy link
Contributor

这个PR 有空 rebase 一下上游哈,然后之前改动的 cpu 返回的在 restricted 策略下需要返回 preferred=true,我看只感知了节点策略,本PR 加上Pod 级别的策略后这部分逻辑没有对齐

apis/extension/numa_aware.go Outdated Show resolved Hide resolved
@KunWuLuan
Copy link
Contributor Author

Already merge the pr with upstream main. And update the policy passed to GetTopologyHints

pkg/scheduler/plugins/deviceshare/topology_hint.go Outdated Show resolved Hide resolved
pkg/scheduler/plugins/nodenumaresource/resource_manager.go Outdated Show resolved Hide resolved
apis/extension/numa_aware.go Outdated Show resolved Hide resolved
apis/extension/numa_aware.go Outdated Show resolved Hide resolved
apis/extension/numa_aware.go Outdated Show resolved Hide resolved
apis/extension/numa_aware.go Show resolved Hide resolved
@ZiMengSheng
Copy link
Contributor

/lgtm

@FillZpp
Copy link
Member

FillZpp commented May 20, 2024

/approve

@ZiMengSheng
Copy link
Contributor

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: FillZpp, ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit eba6094 into koordinator-sh:main May 20, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants