refactor: cleanup preview items on drops page #10344

preschian · 2024-05-24T11:05:34Z

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

Bugfix
Feature
Refactoring

(please remove design and QA checks below if not needed)

Needs Design check

@exezbcz please review

Needs QA check

@kodadot/qa-guild please review

Context

Related: refactor: cleanup free drops component #10336
Related: refactor: adjust hash for metadata #10148. The user can't see the preview drops before minting it, ref: refactor: adjust hash for metadata #10148 (comment).
Closes: Stuck on minting nft drop #10352

Did your issue had any of the "$" label on it?

My DOT address: Payout

Screenshot 📸

My fix has changed something on UI; a screenshot is best to understand changes for others.

netlify · 2024-05-24T11:05:50Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`e28f564`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/665f3372aeed2d0008538ad5
😎 Deploy Preview	https://deploy-preview-10344--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudflare-pages · 2024-05-24T11:07:39Z

Deploying koda-art-prod with Cloudflare Pages

Latest commit:	`e28f564`
Status:	✅ Deploy successful!
Preview URL:	https://430211a8.kodaart-production.pages.dev
Branch Preview URL:	https://refactor--cleanup-preview-dr.kodaart-production.pages.dev

View logs

exezbcz · 2024-05-27T14:45:33Z

linking:

Stuck on minting nft drop #10352

…cleanup-preview-drop-items

* refactor(e2e): modify nft-name test to check the first element in collection.spec.ts

… TIMEOUT * feat(playwright.config.ts): add expect timeout setting * refactor(tests/e2e/collection.spec.ts): remove redundant waitForLoadState * refactor(tests/e2e/collection.spec.ts): simplify nft-name text expectation

…s array for it.each test function

components/collection/drop/modal/PaidMint.vue

tests/randomize.spec.ts

prury · 2024-05-28T14:30:01Z

did some mints using auto-teleport on canary and was unable to reproduce the issue, any ideas?

…ethod from tests

…g in CI environment * refactor(explore.spec.ts, sidebar.spec.ts): remove explicit timeout from toBeVisible assertions

prury · 2024-05-29T12:50:37Z

@preschian sidebar.spec.ts is failing on other PRs as well, investigating.

preschian · 2024-05-29T12:56:10Z

sidebar.spec.ts is failing on other PRs as well, investigating.

I tried to increase the timeout in the playwright global config. Should we increase it again? currently 12s. On local, sidebar.spec.ts looks fine

prury · 2024-05-29T13:07:21Z

sidebar.spec.ts is failing on other PRs as well, investigating.

I tried to increase the timeout in the playwright global config. Should we increase it again? currently 12s. On local, sidebar.spec.ts looks fine

uh, not sure if i understood
from what I've seen you have increased the global test timeout from 1 min to 2 min (1 * 60 * 1000 to 2 * 60 * 1000), and retries from 1 to 3

i would leave the global test timeout at 1 min, meaning that, if a single test takes more than one minute, it would automatically fail(i try to keep each test below 1min)

retries i would also leave at 1, otherwise the test will take a long time to fail (imagine if a test takes 50s and it retries it 3 times)

if you were willing to change the expect timeout(5s default) we have to use: config = { expect: { timeout: 10000 } }

i think sidebar.spec.ts is failing for another yet unknown reason

preschian · 2024-05-29T13:19:12Z

from what I've seen you have increased the global test timeout from 1 min to 2 min (1 * 60 * 1000 to 2 * 60 * 1000), and retries from 1 to 3

Oh sorry, yes this one correct. Not 12s but to 2 min

if you were willing to change the expect timeout(5s default) we have to use: config = { expect: { timeout: 10000 } }

Yes, this is the one I add. Right now, the config:

const TIMEOUT = 2 * 60 * 1000

const config = {
	// ...
	timeout: TIMEOUT,
	expect: {
	  timeout: TIMEOUT,
	},
	// ...
}

…e and retries from 3 to 1

playwright.config.ts

prury · 2024-05-29T13:46:06Z

as i said in dm, tests were failing due to an RPC error, that's why it failed across many PRs
this RPC error prevented the app from getting balances, making the add funds button never to reach load state on an empty account

feel free to revert config or timeout changes in tests, or test the 12s global timeout

hassnian

the only thing is that now we won't be able to see NFT previews while mass-minting , if @exezbcz approves let's go

exezbcz · 2024-06-04T11:45:48Z

hmm weird, the modal does not even load for me

exezbcz · 2024-06-04T11:46:12Z

@hassnian that is the thing, we dont show any previews because what you get is random now

…cleanup-preview-drop-items

preschian · 2024-06-04T15:28:33Z

hmm weird, the modal does not even load for me

let me check

codeclimate · 2024-06-04T15:32:30Z

Code Climate has analyzed commit e28f564 and detected 0 issues on this pull request.

View more on Code Climate.

sonarcloud · 2024-06-04T15:32:41Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

preschian · 2024-06-04T15:34:53Z

hmm weird, the modal does not even load for me

interesting, how about now @exezbcz , probably due to error on rpc side

preschian added 2 commits May 24, 2024 07:08

refactor: skip rendering preview

f019108

refactor: cleanup preview items

5fa7970

Merge branch 'main' of github.com:kodadot/nft-gallery into refactor--…

ea1204b

…cleanup-preview-drop-items

preschian marked this pull request as ready for review May 28, 2024 01:45

preschian requested a review from a team as a code owner May 28, 2024 01:45

preschian requested review from daiagi and Jarsen136 and removed request for a team May 28, 2024 01:45

preschian added 3 commits May 28, 2024 08:52

* test(e2e): add networkidle load state wait in collection.spec.ts

89a7cde

* refactor(e2e): modify nft-name test to check the first element in collection.spec.ts

* refactor(randomize.spec.ts): comment out uidMathDate and use method…

322e6b6

…s array for it.each test function

preschian requested a review from hassnian May 28, 2024 03:18

Jarsen136 reviewed May 28, 2024

View reviewed changes

components/collection/drop/modal/PaidMint.vue Show resolved Hide resolved

tests/randomize.spec.ts Outdated Show resolved Hide resolved

Merge branch 'main' into refactor--cleanup-preview-drop-items

69408cb

preschian added 2 commits May 29, 2024 19:18

* refactor(randomize.spec.ts): remove unused uidMathDate import and m…

4ddd7f2

…ethod from tests

* fix(playwright.config.ts): increase retries from 1 to 3 when runnin…

181b028

…g in CI environment * refactor(explore.spec.ts, sidebar.spec.ts): remove explicit timeout from toBeVisible assertions

* fix(playwright.config.ts): reduce TIMEOUT from 2 minutes to 1 minut…

17595df

…e and retries from 3 to 1

prury reviewed May 29, 2024

View reviewed changes

playwright.config.ts Outdated Show resolved Hide resolved

vikiival requested review from Jarsen136 and prury June 3, 2024 10:19

Jarsen136 approved these changes Jun 3, 2024

View reviewed changes

hassnian approved these changes Jun 4, 2024

View reviewed changes

prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jun 4, 2024

Merge branch 'main' of github.com:kodadot/nft-gallery into refactor--…

3fdad9f

…cleanup-preview-drop-items

revert: e2e stuff

e28f564

prury removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jun 4, 2024

prury approved these changes Jun 4, 2024

View reviewed changes

prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jun 4, 2024

exezbcz added the S-visual-ok-✅ label Jun 4, 2024

prury added this pull request to the merge queue Jun 6, 2024

Merged via the queue into main with commit 97fcbe1 Jun 6, 2024
20 checks passed

prury deleted the refactor--cleanup-preview-drop-items branch June 6, 2024 15:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: cleanup preview items on drops page #10344

refactor: cleanup preview items on drops page #10344

preschian commented May 24, 2024 •

edited

netlify bot commented May 24, 2024 •

edited

cloudflare-pages bot commented May 24, 2024 •

edited

exezbcz commented May 27, 2024

prury commented May 28, 2024

prury commented May 29, 2024

preschian commented May 29, 2024

prury commented May 29, 2024 •

edited

preschian commented May 29, 2024

prury commented May 29, 2024

hassnian left a comment

exezbcz commented Jun 4, 2024

exezbcz commented Jun 4, 2024

preschian commented Jun 4, 2024

codeclimate bot commented Jun 4, 2024

sonarcloud bot commented Jun 4, 2024

preschian commented Jun 4, 2024

refactor: cleanup preview items on drops page #10344

refactor: cleanup preview items on drops page #10344

Conversation

preschian commented May 24, 2024 • edited

PR Type

Needs Design check

Needs QA check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

netlify bot commented May 24, 2024 • edited

✅ Deploy Preview for koda-canary ready!

cloudflare-pages bot commented May 24, 2024 • edited

Deploying koda-art-prod with Cloudflare Pages

exezbcz commented May 27, 2024

prury commented May 28, 2024

prury commented May 29, 2024

preschian commented May 29, 2024

prury commented May 29, 2024 • edited

preschian commented May 29, 2024

prury commented May 29, 2024

hassnian left a comment

Choose a reason for hiding this comment

exezbcz commented Jun 4, 2024

exezbcz commented Jun 4, 2024

preschian commented Jun 4, 2024

codeclimate bot commented Jun 4, 2024

sonarcloud bot commented Jun 4, 2024

Quality Gate passed

preschian commented Jun 4, 2024

preschian commented May 24, 2024 •

edited

netlify bot commented May 24, 2024 •

edited

cloudflare-pages bot commented May 24, 2024 •

edited

prury commented May 29, 2024 •

edited