Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated back #1146

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

fl0w
Copy link
Contributor

@fl0w fl0w commented Feb 14, 2018

#1114

Notice it being branched from fl0w:refactor-back, needs rebase post merge.

@codecov
Copy link

codecov bot commented Feb 14, 2018

Codecov Report

Merging #1146 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1146      +/-   ##
==========================================
+ Coverage   99.73%   99.73%   +<.01%     
==========================================
  Files           5        5              
  Lines         374      375       +1     
==========================================
+ Hits          373      374       +1     
  Misses          1        1
Impacted Files Coverage Δ
lib/context.js 96.96% <ø> (ø) ⬆️
lib/response.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 916f914...5cdd01c. Read the comment docs.

@fl0w fl0w added this to the v3.0.0 milestone Feb 16, 2018
@niftylettuce
Copy link
Contributor

Any reason besides not having someone review this yet @fl0w to not merge? Would this go out in v3?

@fl0w
Copy link
Contributor Author

fl0w commented Jan 7, 2019

This is branched off of #1115 which haven't been merged. #1115 is a semver minor fix for 2.x line and it should be merged first. This should only be merged when work on 3.x begins IMO.

I'm not sure why it never got merged, I wouldn't want to speculate.

Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants