Types: add read-only versions of observables #2563
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Observables can be cast to readonly observable to indicate that they shouldn't be mutated, or functions can accept readonly observables to indicate that they won't mutate them
ObservableArrays can be cast to this type to prevent mutation, or taken as function arguments to indicate that the function will not mutate the observable
Computeds can be cast to this type to prevent mutation, or taken as function arguments to indicate that the function will not write to this computed In theory certain ko.computed overrides should return this, but this is not currently the case
To avoid major breaking changes, use `Computed` for read-only computeds fix some typos expand readonly tests, especially using @ts-expect-error
This was referenced Feb 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2476, this also sets the default return value of
ko.computedto a read-only Computed type.