Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semicolon issues #2384

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/binding/bindingAttributeSyntax.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
self[contextSubscribable] = undefined;
}
}
}
};

// Extend the binding context hierarchy with a new view model object. If the parent context is watching
// any observables, the new child context will automatically get a dependency on the parent context.
Expand Down Expand Up @@ -285,7 +285,7 @@
function validateThatBindingIsAllowedForVirtualElements(bindingName) {
var validator = ko.virtualElements.allowedBindings[bindingName];
if (!validator)
throw new Error("The binding '" + bindingName + "' cannot be used with virtual elements")
throw new Error("The binding '" + bindingName + "' cannot be used with virtual elements");
}

function applyBindingsToDescendantsInternal(bindingContext, elementOrVirtualElement) {
Expand Down Expand Up @@ -511,12 +511,12 @@
'shouldBindDescendants': shouldBindDescendants,
'bindingContextForDescendants': shouldBindDescendants && contextToExtend
};
};
}

ko.storedBindingContextForNode = function (node) {
var bindingInfo = ko.utils.domData.get(node, boundElementDomDataKey);
return bindingInfo && bindingInfo.context;
}
};

function getBindingContext(viewModelOrBindingContext, extendContextCallback) {
return viewModelOrBindingContext && (viewModelOrBindingContext instanceof ko.bindingContext)
Expand Down
6 changes: 3 additions & 3 deletions src/binding/defaultBindings/checked.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ ko.bindingHandlers['checked'] = {
}
ko.expressionRewriting.writeValueToProperty(modelValue, allBindings, 'checked', elemValue, true);
}
};
}

function updateView() {
// This updates the view value from the model value.
Expand All @@ -87,7 +87,7 @@ ko.bindingHandlers['checked'] = {
// Otherwise, being checked means that the checkbox or radio button's value corresponds to the model value
element.checked = (checkedValue() === modelValue);
}
};
}

var isCheckbox = element.type == "checkbox",
isRadio = element.type == "radio";
Expand All @@ -105,7 +105,7 @@ ko.bindingHandlers['checked'] = {

// IE 6 won't allow radio buttons to be selected unless they have a name
if (isRadio && !element.name)
ko.bindingHandlers['uniqueName']['init'](element, function() { return true });
ko.bindingHandlers['uniqueName']['init'](element, function() { return true; });

// Set up two computeds to update the binding:

Expand Down
2 changes: 1 addition & 1 deletion src/binding/defaultBindings/enableDisable.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ ko.bindingHandlers['enable'] = {

ko.bindingHandlers['disable'] = {
'update': function (element, valueAccessor) {
ko.bindingHandlers['enable']['update'](element, function() { return !ko.utils.unwrapObservable(valueAccessor()) });
ko.bindingHandlers['enable']['update'](element, function() { return !ko.utils.unwrapObservable(valueAccessor()); });
}
};
2 changes: 1 addition & 1 deletion src/binding/defaultBindings/event.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ function makeEventHandlerShortcut(eventName) {
};
return ko.bindingHandlers['event']['init'].call(this, element, newValueAccessor, allBindings, viewModel, bindingContext);
}
}
};
}

ko.bindingHandlers['event'] = {
Expand Down
2 changes: 1 addition & 1 deletion src/binding/defaultBindings/options.js
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ ko.bindingHandlers['options'] = {
callback = function(arrayEntry, newOptions) {
setSelectionCallback(arrayEntry, newOptions);
ko.dependencyDetection.ignore(allBindings.get('optionsAfterRender'), null, [newOptions[0], arrayEntry !== captionPlaceholder ? arrayEntry : undefined]);
}
};
}

ko.utils.setDomNodeChildrenFromArrayMapping(element, filteredArray, optionForArrayItem, arrayToDomNodeChildrenOptions, callback);
Expand Down
8 changes: 4 additions & 4 deletions src/binding/defaultBindings/value.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,15 @@ ko.bindingHandlers['value'] = {
var modelValue = valueAccessor();
var elementValue = ko.selectExtensions.readValue(element);
ko.expressionRewriting.writeValueToProperty(modelValue, allBindings, 'value', elementValue);
}
};

// Workaround for https://github.com/SteveSanderson/knockout/issues/122
// IE doesn't fire "change" events on textboxes if the user selects a value from its autocomplete list
var ieAutoCompleteHackNeeded = ko.utils.ieVersion && isInputElement && element.type == "text"
&& element.autocomplete != "off" && (!element.form || element.form.autocomplete != "off");
if (ieAutoCompleteHackNeeded && ko.utils.arrayIndexOf(eventsToCatch, "propertychange") == -1) {
ko.utils.registerEventHandler(element, "propertychange", function () { propertyChangedFired = true });
ko.utils.registerEventHandler(element, "focus", function () { propertyChangedFired = false });
ko.utils.registerEventHandler(element, "propertychange", function () { propertyChangedFired = true; });
ko.utils.registerEventHandler(element, "focus", function () { propertyChangedFired = false; });
ko.utils.registerEventHandler(element, "blur", function() {
if (propertyChangedFired) {
valueUpdateHandler();
Expand Down Expand Up @@ -78,7 +78,7 @@ ko.bindingHandlers['value'] = {
} else {
ko.dependencyDetection.ignore(valueUpdateHandler); // reset the model to match the element
}
}
};
} else {
updateFromModel = function () {
var newValue = ko.utils.unwrapObservable(valueAccessor());
Expand Down
2 changes: 1 addition & 1 deletion src/binding/defaultBindings/visibleHidden.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ ko.bindingHandlers['visible'] = {

ko.bindingHandlers['hidden'] = {
'update': function (element, valueAccessor) {
ko.bindingHandlers['visible']['update'](element, function() { return !ko.utils.unwrapObservable(valueAccessor()) });
ko.bindingHandlers['visible']['update'](element, function() { return !ko.utils.unwrapObservable(valueAccessor()); });
}
};
2 changes: 1 addition & 1 deletion src/binding/editDetection/arrayToDomNodeChildren.js
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@
// Finally call afterMove and afterAdd callbacks
callCallback(options['afterMove'], itemsForMoveCallbacks);
callCallback(options['afterAdd'], itemsForAfterAddCallbacks);
}
};
})();

ko.exportSymbol('utils.setDomNodeChildrenFromArrayMapping', ko.utils.setDomNodeChildrenFromArrayMapping);
4 changes: 2 additions & 2 deletions src/components/customElements.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
}

return allBindings;
}
};

var nativeBindingProviderInstance = new ko.bindingProvider();

Expand Down Expand Up @@ -94,7 +94,7 @@
return function(componentName) {
document.createElement(componentName); // Allows IE<9 to parse markup containing the custom element
return originalFunction.apply(this, arguments);
}
};
})(ko.components['register']);

// Whenever you create a document fragment, enable all preregistered component names as custom elements
Expand Down
2 changes: 1 addition & 1 deletion src/subscribables/dependentObservable.js
Original file line number Diff line number Diff line change
Expand Up @@ -525,5 +525,5 @@ ko.pureComputed = function (evaluatorFunctionOrOptions, evaluatorFunctionTarget)
evaluatorFunctionOrOptions['pure'] = true;
return ko.computed(evaluatorFunctionOrOptions, evaluatorFunctionTarget);
}
}
};
ko.exportSymbol('pureComputed', ko.pureComputed);
2 changes: 1 addition & 1 deletion src/subscribables/extenders.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ ko.extenders = {

'deferred': function(target, options) {
if (options !== true) {
throw new Error('The \'deferred\' extender only accepts the value \'true\', because it is not supported to turn deferral off once enabled.')
throw new Error('The \'deferred\' extender only accepts the value \'true\', because it is not supported to turn deferral off once enabled.');
}

if (!target._deferUpdates) {
Expand Down
4 changes: 2 additions & 2 deletions src/subscribables/mappingHelpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,12 @@
visitorCallback(propertyName);
}
}
};
}

function objectLookup() {
this.keys = [];
this.values = [];
};
}

objectLookup.prototype = {
constructor: objectLookup,
Expand Down
2 changes: 1 addition & 1 deletion src/subscribables/observable.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ ko.observable = function (initialValue) {
}

return observable;
}
};

// Define prototype for observables
var observableFn = {
Expand Down
2 changes: 1 addition & 1 deletion src/subscribables/observableArray.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ ko.observableArray['fn'] = {
'destroyAll': function (arrayOfValues) {
// If you passed zero args, we destroy everything
if (arrayOfValues === undefined)
return this['destroy'](function() { return true });
return this['destroy'](function() { return true; });

// If you passed an arg, we interpret it as an array of entries to destroy
if (!arrayOfValues)
Expand Down
4 changes: 2 additions & 2 deletions src/subscribables/subscribable.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ ko.subscription.prototype.disposeWhenNodeIsRemoved = function (node) {
ko.subscribable = function () {
ko.utils.setPrototypeOfOrExtend(this, ko_subscribable_fn);
ko_subscribable_fn.init(this);
}
};

var defaultEvent = "change";

Expand Down Expand Up @@ -174,7 +174,7 @@ var ko_subscribable_fn = {
},

toString: function() {
return '[object Object]'
return '[object Object]';
},

extend: applyExtenders
Expand Down
2 changes: 1 addition & 1 deletion src/templating/native/nativeTemplateEngine.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ko.nativeTemplateEngine = function () {
this['allowTemplateRewriting'] = false;
}
};

ko.nativeTemplateEngine.prototype = new ko.templateEngine();
ko.nativeTemplateEngine.prototype.constructor = ko.nativeTemplateEngine;
Expand Down
2 changes: 1 addition & 1 deletion src/templating/templateRewriting.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ ko.templateRewriting = (function () {
}
});
}
}
};
})();


Expand Down
4 changes: 2 additions & 2 deletions src/templating/templateSources.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
tagNameLower == "template" && element.content && element.content.nodeType === 11 ? templateTemplate :
templateElement;
}
}
};

ko.templateSources.domElement.prototype['text'] = function(/* valueToWrite */) {
var elemContentsProperty = this.templateType === templateScript ? "text"
Expand Down Expand Up @@ -113,7 +113,7 @@

ko.templateSources.anonymousTemplate = function(element) {
this.domElement = element;
}
};
ko.templateSources.anonymousTemplate.prototype = new ko.templateSources.domElement();
ko.templateSources.anonymousTemplate.prototype.constructor = ko.templateSources.anonymousTemplate;
ko.templateSources.anonymousTemplate.prototype['text'] = function(/* valueToWrite */) {
Expand Down
2 changes: 1 addition & 1 deletion src/templating/templating.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
if ((templateEngine != undefined) && !(templateEngine instanceof ko.templateEngine))
throw new Error("templateEngine must inherit from ko.templateEngine");
_templateEngine = templateEngine;
}
};

function invokeForEachNodeInContinuousRange(firstNode, lastNode, action) {
var node, nextInQueue = firstNode, firstOutOfRangeNode = ko.virtualElements.nextSibling(lastNode);
Expand Down
10 changes: 5 additions & 5 deletions src/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ ko.utils = (function () {
var result = [];
for (var i = 0, j = arrayLikeObject.length; i < j; i++) {
result.push(arrayLikeObject[i]);
};
}
return result;
},

Expand All @@ -522,13 +522,13 @@ ko.utils = (function () {
getFormFields: function(form, fieldName) {
var fields = ko.utils.makeArray(form.getElementsByTagName("input")).concat(ko.utils.makeArray(form.getElementsByTagName("textarea")));
var isMatchingField = (typeof fieldName == 'string')
? function(field) { return field.name === fieldName }
: function(field) { return fieldName.test(field.name) }; // Treat fieldName as regex or object containing predicate
? function(field) { return field.name === fieldName; }
: function(field) { return fieldName.test(field.name); }; // Treat fieldName as regex or object containing predicate
var matches = [];
for (var i = fields.length - 1; i >= 0; i--) {
if (isMatchingField(fields[i]))
matches.push(fields[i]);
};
}
return matches;
},

Expand Down Expand Up @@ -591,7 +591,7 @@ ko.utils = (function () {
options['submitter'] ? options['submitter'](form) : form.submit();
setTimeout(function () { form.parentNode.removeChild(form); }, 0);
}
}
};
}());

ko.exportSymbol('utils', ko.utils);
Expand Down
2 changes: 1 addition & 1 deletion src/virtualElements.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
return isEndComment(node) && !(ko.utils.domData.get(node, matchedEndCommentDataKey));
}

var matchedEndCommentDataKey = "__ko_matchedEndComment__"
var matchedEndCommentDataKey = "__ko_matchedEndComment__";

function getVirtualChildren(startComment, allowUnbalanced) {
var currentNode = startComment;
Expand Down