Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bindingInfo to binding exception #2123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added bindingInfo to binding exception #2123

wants to merge 1 commit into from

Conversation

cbastos
Copy link

@cbastos cbastos commented Sep 16, 2016

Added DOM element node and binding context info to 'unable to process binding' exception.
With this change we can retrieve more info in exception management:

For example: viewmodel constructor and failing dom element node.
ko.onError = function(e){
console.log({ viewModel : e.bindingInfo.context["$component"].constructor , node : e.bindingInfo.node });
}

Added DOM element node and binding context info to 'unable to process binding' exception.
@brianmhunt
Copy link
Member

This was one of the first issues addressed and will definitely be covered in tko. ( when it builds ... Soon! )

this is a pretty innocuous add to ko 3.4 but probably not API compatible going forward.

Want to leave it open or wait for tko?

@cbastos
Copy link
Author

cbastos commented Sep 18, 2016

I would like to be included in both versions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants