Remove SelfSigned issuer from released transport-encryption artifacts
#7905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a SelfSigned issuer is not recommended by cert-manager and currently we're shipping it in the tranport-encryption feature artifact. Moving forward, we will not ship a SelfSigned issuer in the `eventing-tls-networking.yaml` artifacts and we will document, as a prerequisite, how to create a `ClusterIssuer` for eventing components so that by users can bring their own choosen issuers [1]. [1] https://cert-manager.io/docs/concepts/issuer/ Signed-off-by: Pierangelo Di Pilato <[email protected]>
knative-prow
bot
added
area/test-and-release
|
@pierDipi can you fix the boilerplate issue? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7905 +/- ##
==========================================
- Coverage 69.22% 69.13% -0.09%
==========================================
Files 339 341 +2
Lines 19494 15829 -3665
==========================================
- Hits 13494 10943 -2551
+ Misses 5337 4213 -1124
- Partials 663 673 +10 ☔ View full report in Codecov by Sentry. |
|
@creydr I've just copied this file from another placeholder, so I think it's ok to ignore the error there |
pierDipi
force-pushed
the
no-selfsigned-issuer
branch
2 times, most recently
from
ab5edb7
to
8eeee70
Compare
knative-prow
bot
added
size/M
pierDipi
force-pushed
the
no-selfsigned-issuer
branch
from
8eeee70
to
9e95280
Compare
knative-prow
bot
added
size/S
Signed-off-by: Pierangelo Di Pilato <[email protected]>
pierDipi
force-pushed
the
no-selfsigned-issuer
branch
from
9e95280
to
0cbefa3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a SelfSigned issuer is not recommended by cert-manager and currently we're shipping it in the tranport-encryption feature artifact.
Moving forward, we will not ship a SelfSigned issuer in the
eventing-tls-networking.yamlartifacts and we will document, as a prerequisite, how to create aClusterIssuerfor eventing components so that by users can bring their own choosen issuer [1].[1] https://cert-manager.io/docs/concepts/issuer/
Fixes #
Proposed Changes
transport-encryptionartifactsPre-review Checklist
Release Note
Docs