Option for smaller Popover #177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thank you for your contribution! I'll review it a bit later |
|
Hmm I think I found a bug too which doesn't seem to happen all the time. Sometimes, if you pick a song while the popover is open, it will mess up the picture or the time, or not show anything at all. Seems to happen with either popup. Can you replicate the issue? Let me know if it was somehow introduced with this PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good evening!
I have used your app for a while, and really like it! 馃憦
But I think it could benefit from allowing the user from choosing a smaller popover, and thus creating this PR.
I only added English and Portuguese versions so far, though. If you are interested, feel free to tell me the additional translations or changes before squashing the commits.