Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Themes #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Themes #117

wants to merge 1 commit into from

Conversation

kahless364
Copy link

@kahless364 kahless364 commented Dec 12, 2019

This commit fixes all 3 themes to adjust for changes made on todo.microsoft.com, such as list groups.

Fixes:
#99 The "Assigned to me" don't have the black theme background
#113 Icons in themes broken
#63 Text is a little too dark in Black/Dark themes
#119 Today sidebar does not respect Dark mode setting

Screenshots:
Sepia
sepia-mode

Dark
dark-mode

Black
black-mode

Tests:
No new errors (these are existing broken tests on master)
tests

@825i
Copy link

825i commented Dec 15, 2019

You're a legend. Thanks for doing this @kahless364 !

@Feromrk
Copy link

Feromrk commented Dec 15, 2019

Awesome! Just discovered this beautiful project and wanted to start digging into correcting the color of the font, which is too dark. But you did it already =)

@825i
Copy link

825i commented Jan 31, 2020

@kahless364 I've merged this with my own fork and credited you in the readme. Everything looks superb. Thanks so much. I'm going to make edits to my own branch because @klaussinani hasn't replied to any emails and seems to be busy on other projects.

Thanks again to both of you for your hard work. I'll do my best on maintaining my own fork. If anyone wants permission to make changes to it, feel free to ask.

@haeringer
Copy link

haeringer commented Feb 2, 2020

@kahless364 I've merged this with my own fork and credited you in the readme. Everything looks superb. Thanks so much. I'm going to make edits to my own branch because @klaussinani hasn't replied to any emails and seems to be busy on other projects.

Thanks @pythonInRelay for publishing a version with those fixes merged (and of course thanks to @kahless364 for the fixes themselves!). Do you have a hint for me how to install it from source on Linux or how to build a package myself? I have tried to create a snap with the below snapcraft.yaml, but the Multipass build fails with errors electron-builder not found and Failed to run '/root/parts/ao/npm/bin/yarn install --offline --prod although the electron-builder dependancy is listed in the package.json file. Sorry, got no experience with Electron... Am I on the wrong path maybe?

name: ao
base: core18
version: '6.9.1'
summary: Microsoft To-Do desktop app
description: An elegant Microsoft To-Do desktop app for Linux

grade: devel
confinement: devmode

parts:
  ao:
    source: https://github.com/pythonInRelay/ao/archive/6.9.1.tar.gz
    plugin: nodejs

apps:
  ao:
    command: ao

@825i
Copy link

825i commented Feb 2, 2020

@kahless364 I've merged this with my own fork and credited you in the readme. Everything looks superb. Thanks so much. I'm going to make edits to my own branch because @klaussinani hasn't replied to any emails and seems to be busy on other projects.

Thanks @pythonInRelay for publishing a version with those fixes merged (and of course thanks to @kahless364 for the fixes themselves!). Do you have a hint for me how to install it from source on Linux or how to build a package myself? I have tried to create a snap with the below snapcraft.yaml, but the Multipass build fails with errors electron-builder not found and Failed to run '/root/parts/ao/npm/bin/yarn install --offline --prod although the electron-builder dependancy is listed in the package.json file. Sorry, got no experience with Electron... Am I on the wrong path maybe?

name: ao
base: core18
version: '6.9.1'
summary: Microsoft To-Do desktop app
description: An elegant Microsoft To-Do desktop app for Linux

grade: devel
confinement: devmode

parts:
  ao:
    source: https://github.com/pythonInRelay/ao/archive/6.9.1.tar.gz
    plugin: nodejs

apps:
  ao:
    command: ao

Hey mate. I'm having a similar issue as I have no idea how @klaussinani managed to build this. I've been trying to make a .deb file out of it but I assume snap would be better for auto-updates. I'll let you know if/when I've cracked it or made any progress. Thanks for the info yourself though, but yeah unfortunately I'm no expert with Electron either. You too let me know if you manage to work it out. Thanks!

@haeringer
Copy link

Ahem... reading helps: I missed the development instructions in the readme. Indeed I was on the wrong path by using snapcraft; I was wondering already why there wouldn't be a snapcraft.yaml in the repository. ;)
Simply running npm install and npm run release works just fine. Then install the snap via snap install --devmode dist/ao_6.9.1_amd64.snap (devmode because it's not signed by the Snap Store).

@825i
Copy link

825i commented Feb 2, 2020 via email

@825i
Copy link

825i commented Feb 5, 2020

Ahem... reading helps: I missed the development instructions in the readme. Indeed I was on the wrong path by using snapcraft; I was wondering already why there wouldn't be a snapcraft.yaml in the repository. ;)
Simply running npm install and npm run release works just fine. Then install the snap via snap install --devmode dist/ao_6.9.1_amd64.snap (devmode because it's not signed by the Snap Store).

Managed to build and upload the release packages here: https://github.com/pythonInRelay/ao/releases/tag/6.9.1

A huge thanks to you @haeringer for helping with this. Looks great on my device. Just need to figure out a way to fix the white emoji background on dark themes if you use them in your To-Do lists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants