Fix compliance cookie not deleting if domain specified as .example.com #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using new option collapseConsentOptions the toggles can be easily set to collapsed by default, giving a simpler user experience on initial page/site landing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On deploying to our staging environment the compliance cookie was refusing to delete on clicking the reset consent button e.g:
The initial consent manager showed until the page was refreshed and the previous consent restored from the not-yet-deleted-cookie, resulting in non-compliance.
It was working fine on
localhostbut notstaging.ourdomain.comwith the "cookieDomain" set to ".staging.ourdomain.com".I hope this is a relevant / good change, if good and you need the /dist/ contents regenerated and committed/pushed please let me know.