Fix AnchorLayout children height bug (#8669) #8670
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer merge checklist
Component: xxx
label.api-deprecation
orapi-break
label.release-highlight
label to be highlighted in release notes.versionadded
,versionchanged
as needed.#8669
AnchorLayout
saves thesize
of the child widget before recalculating it and putting it back. Settingsize
means thatwidth
will be set first, and thenheight
will be set. Ifwidth
handler sets a newheight
value,AnchorLayout
will immediately replace it with the height value that it was originally going to set. This is not what it should do, in case it does not control the height of the child widget. It should not set theheight
at all if thesize_hint_y
value forbids him to change it. Even if it is going to set the same value as it was before, it is quite possible that in the process the value will change and the child widget will get the wrongheight
.