Refrain from re-initializing query-fn if queries files not modified #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a good idea, it's a nice quality of life improvement for the development experience. 👍 |
|
Cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps this is overkill, but since a lot of your components will probably depend on the :db.sql/query-fn component the fact that it was not resumable caused pretty much all components to be reloaded when doing
(reset).This PR adds an explicit check if any of the hugsql queries files are modified, and if not the old implementation is returned upon resume.
Requires Java 7+ since java.nio.file APIs are used for getting the modification time. (java.io.File#lastModified unfortunately always seem to return 0, at least on macOS).