Fix for #1355 #1932
Open
Fix for #1355 #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new method allows to evaluate the actual plan in a future date, by looking at future transitions.
This allows the creation of subscriptions to add-on plans only compatible with a base plan pending activation.
This test checks if pending incompatible add-ons are canceled when undoing a change plan. See GH#1135. The test is currently disabled, as it is failing because the needed logic has not been implemented yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the #1355, by allowing the future creation of add-ons only compatible with a pending plan.
The implemented solution opens a new bug for a corner case: if an add-on gets created for a pending base plan, and the pending operation gets canceled, the new add-on does not get canceled, ending with having an add-on incompatible with the active base plan.
I think this could be solved by applying on undo changes checks similar to the ones used when changing the base subscription (leading to the cancellation of the incompatible add-ons, see
DefaultSubscriptionBaseApiService::doChangePlan). The last commit of this PR adds a (disabled) test to check this behavior.