perf(test): check tool versions in parallel

khuedoan · Oct 3, 2022 · 5071183 · 5071183
1 parent a5a6db1
commit 5071183
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/test/tools_test.go b/test/tools_test.go
@@ -30,13 +30,17 @@ func TestToolsVersions(t *testing.T) {
  }
 
  for _, tool := range tools {
- params := version_checker.CheckVersionParams{
- BinaryPath: tool.binaryPath,
- VersionConstraint: tool.versionConstraint,
- WorkingDir: ".",
- }
+ tool := tool // https://github.com/golang/go/wiki/CommonMistakes#using-goroutines-on-loop-iterator-variables
+ t.Run(tool.binaryPath, func(t *testing.T) {
+ t.Parallel()
+ params := version_checker.CheckVersionParams{
+ BinaryPath: tool.binaryPath,
+ VersionConstraint: tool.versionConstraint,
+ WorkingDir: ".",
+ }
 
- version_checker.CheckVersion(t, params)
+ version_checker.CheckVersion(t, params)
+ })
  }
 }