-
-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cs_pinyin] CS-Pinyin keyboard initial public version #64
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README.md: Replace "DESCRIPTION" with description.
HISTORY.md: "Template" in first line should be changed to project name (or deleted).
\source\images*.bmp: Names of some files contain upper case letters. Not sure if this is a potential problem or not.
\source\docs: Are "About the Four Corner Method.pdf" and "The Four Corner Index Lookup Method.pdf" distinct documents?
\source\docs: "Using Simplified Chinese.pdf" contains references to Keyman version 6, and to tavultesoft.com
\source\docs: Are "Using Simplified Chinese.pdf" and "Using the CS-Pinyin IMX.pdf" distinct documents?
\source\images\CS-Pinyin Install.bmp: claims "© 2011 Tavultesoft"
"Readme" tab of installation package dialog references "copyright 2003-2011 by Tavultesoft", and tavultesoft.com (In contrast, welcome.htm has "copyright 2017 SIL International".)
Running build.cmd failed until a build folder was created manually.
Installing with Keyman Configuration seems to add "Uninstall Simplified Chinese" shortcut to start menu.
|
When I try to build I get this error:
I think the .kps is looking in the wrong place for the .dlls? A lot of the documentation still talks about Tavultesoft and Keyman 6. |
I've just added the work-in-progress label to clarify that this keyboard is not yet really ready for review. The content was put online to give another developer access to the source for their own purposes and I will continue to prepare this for release as time permits. Do you think we should close the PR and reopen it later? Or just leave it open as a hint to yours truly that something should be done about it? |
The work in progress label is helpful. |
Missing files in the package have been copied from the legacy .kmp and put in the /build folder. Those files are: imxconfig.exe, KeymnIMX.dll and KeymnIMX.x64.dll. The tweaks fix the errors, but the keyboard doesn't function well yet. It needs further investigation. Also, the content of the README.md and CS-Pinyin ReadMe.html have been updated. |
Note: those files are supposed to be built during the keyboard build
process but the build script needs updating to make it work with the new
build.sh infrastructure.
…On Thu, 26 Oct 2017 at 2:03 pm, Makara ***@***.***> wrote:
Missing files in the package have been copied from the legacy .kmp and put
in the /build folder. Those files are: imxconfig.exe, KeymnIMX.dll and
KeymnIMX.x64.dll.
The tweaks fix the errors, but the keyboard doesn't function well yet. It
needs further investigation.
Also, the content of the README.md and CS-Pinyin ReadMe.html have been
updated.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AESjvc2h0L0jMWY56Klvp3rl9jraPeEGks5swC7BgaJpZM4OkzN2>
.
|
@mcdurdin Two years ago you wrote: "Do you think we should close the PR and reopen it later? Or just leave it open as a hint to yours truly that something should be done about it?" How well has that hint been working? ;) |
Related: #219 |
@DavidLRowe ask me again in two years. Currently my to do list is probably about 5 years long and getting longer. |
body { | ||
margin: 30px; | ||
font-family: 'Arial Unicode MS', Helvetica, sans-serif; | ||
font-size: 10pt;color: #2D2C2C;} | ||
img {border: none; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI if you resume this PR, I removed this styling block on keymanapp/help.keyman.com#923 and it seemed to fix the page layout
Previously the FindWindow would just find the first window with ClassName KM_IMX and then see if it was visible this change check all windows. Only at most one will be, if this is the case then the context is not reset.
Since we need commit d5a878 to guarnteed the simplified Chinese keyboard works in more then one open application. This PR needs the work done to get it accepted and merged.
|
Four years ago on June 18, 2020 you asked us to ask you in 2 years. Is there any likelihood this will be done @mcdurdin? |
This is a public version of the CS-Pinyin keyboard (from keyman-keyboards-internal). It contains all the files necessary to build the keyboard and the DLLs that go with it.
I will be checking the build agent to ensure that it can build the DLLs.