Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cs_pinyin] CS-Pinyin keyboard initial public version #64

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Jul 27, 2017

This is a public version of the CS-Pinyin keyboard (from keyman-keyboards-internal). It contains all the files necessary to build the keyboard and the DLLs that go with it.

I will be checking the build agent to ensure that it can build the DLLs.

@DavidLRowe DavidLRowe self-assigned this Aug 1, 2017
Copy link
Contributor

@DavidLRowe DavidLRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md: Replace "DESCRIPTION" with description.

HISTORY.md: "Template" in first line should be changed to project name (or deleted).

\source\images*.bmp: Names of some files contain upper case letters. Not sure if this is a potential problem or not.

\source\docs: Are "About the Four Corner Method.pdf" and "The Four Corner Index Lookup Method.pdf" distinct documents?

\source\docs: "Using Simplified Chinese.pdf" contains references to Keyman version 6, and to tavultesoft.com

\source\docs: Are "Using Simplified Chinese.pdf" and "Using the CS-Pinyin IMX.pdf" distinct documents?

\source\images\CS-Pinyin Install.bmp: claims "© 2011 Tavultesoft"

"Readme" tab of installation package dialog references "copyright 2003-2011 by Tavultesoft", and tavultesoft.com (In contrast, welcome.htm has "copyright 2017 SIL International".)

Running build.cmd failed until a build folder was created manually.

Installing with Keyman Configuration seems to add "Uninstall Simplified Chinese" shortcut to start menu.

@mcdurdin
Copy link
Member Author

mcdurdin commented Aug 7, 2017

  • .cfx file has the wrong name (should match keyboard base name).
  • Even when .cfx is named correctly, the keyboard isn't working.

@LornaSIL
Copy link
Contributor

When I try to build I get this error:

cs_pinyin.kps: Warning: Warning: File ...\keyboards\cs_pinyin\source\..\build\KeymnIMX.dll does not exist.
cs_pinyin.kps: Warning: Warning: File ...\keyboards\cs_pinyin\source\..\build\imxconfig.exe does not exist.
cs_pinyin.kps: Warning: Warning: File ...\keyboards\cs_pinyin\source\..\build\KeymnIMX.x64.dll does not exist.

I think the .kps is looking in the wrong place for the .dlls?

A lot of the documentation still talks about Tavultesoft and Keyman 6.

@mcdurdin
Copy link
Member Author

I've just added the work-in-progress label to clarify that this keyboard is not yet really ready for review. The content was put online to give another developer access to the source for their own purposes and I will continue to prepare this for release as time permits.

Do you think we should close the PR and reopen it later? Or just leave it open as a hint to yours truly that something should be done about it?

@LornaSIL
Copy link
Contributor

LornaSIL commented Oct 2, 2017

The work in progress label is helpful.

@MakaraSok
Copy link
Collaborator

Missing files in the package have been copied from the legacy .kmp and put in the /build folder. Those files are: imxconfig.exe, KeymnIMX.dll and KeymnIMX.x64.dll.

The tweaks fix the errors, but the keyboard doesn't function well yet. It needs further investigation.

Also, the content of the README.md and CS-Pinyin ReadMe.html have been updated.

@mcdurdin
Copy link
Member Author

mcdurdin commented Oct 26, 2017 via email

@MakaraSok MakaraSok changed the title CS-Pinyin keyboard initial public version [cs_pinyin] CS-Pinyin keyboard initial public version Feb 13, 2018
@mcdurdin mcdurdin added the new label Feb 25, 2018
@DavidLRowe DavidLRowe added this to Backlog in Keyboards May 31, 2018
@DavidLRowe
Copy link
Contributor

@mcdurdin Two years ago you wrote: "Do you think we should close the PR and reopen it later? Or just leave it open as a hint to yours truly that something should be done about it?" How well has that hint been working? ;)

@DavidLRowe
Copy link
Contributor

Related: #219

@mcdurdin
Copy link
Member Author

@DavidLRowe ask me again in two years. Currently my to do list is probably about 5 years long and getting longer.

Comment on lines +3 to +7
body {
margin: 30px;
font-family: 'Arial Unicode MS', Helvetica, sans-serif;
font-size: 10pt;color: #2D2C2C;}
img {border: none; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI if you resume this PR, I removed this styling block on keymanapp/help.keyman.com#923 and it seemed to fix the page layout

Previously the FindWindow would just find the first window
with ClassName KM_IMX and then see if it was visible
this change check all windows. Only at most one will be, if this
is the case then the context is not reset.
@rc-swag
Copy link

rc-swag commented Apr 30, 2024

Since we need commit d5a878 to guarnteed the simplified Chinese keyboard works in more then one open application. This PR needs the work done to get it accepted and merged.
TODO:

  • introduce build.sh so the KeymnIMX.dll, KeymnIMX.x64.dll and imxconfig.exe projects can be built on the build agents
  • Update documentation references to specific Keyman Versions, and Tavultesoft where required. See previous comments in this PR thread. Found the source Simplified Chinese.doc

@LornaSIL
Copy link
Contributor

ask me again in two years. Currently my to do list is probably about 5 years long and getting longer.

Four years ago on June 18, 2020 you asked us to ask you in 2 years. Is there any likelihood this will be done @mcdurdin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Keyboards
  
Backlog
Development

Successfully merging this pull request may close these issues.

None yet

7 participants