Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[samaritan] New keyboard #2824

Merged
merged 2 commits into from
Jun 17, 2024
Merged

[samaritan] New keyboard #2824

merged 2 commits into from
Jun 17, 2024

Conversation

LornaSIL
Copy link
Contributor

No description provided.

@LornaSIL LornaSIL added this to Awaiting approval in Keyboards Jun 14, 2024
DavidLRowe
DavidLRowe approved these changes Jun 15, 2024
View reviewed changes
Copy link
Contributor

@DavidLRowe DavidLRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image for shift layer has a square box on the 4/$ key. Is this intended? If not, dismiss the review and change.

@mcdurdin mcdurdin mentioned this pull request Jun 16, 2024
Closed
@LornaSIL
Copy link
Contributor Author

Image for shift layer has a square box on the 4/$ key. Is this intended?

Not exactly, but I couldn't find a font with the script and that symbol. I think we can let it go for now.

@LornaSIL LornaSIL merged commit e12c0e7 into keymanapp:master Jun 17, 2024
2 checks passed
Keyboards automation moved this from Awaiting approval to Done Jun 17, 2024
@LornaSIL LornaSIL deleted the samaritan branch June 17, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darcywong00 darcywong00 darcywong00 left review comments

@DavidLRowe DavidLRowe DavidLRowe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Keyboards
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LornaSIL @darcywong00 @DavidLRowe