-
-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sgaw_karen] Initial submission of sgaw_karen keyboard #2752
base: master
Are you sure you want to change the base?
Conversation
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
Thanks for your keyboard submission! There are a few things that need fixing up in the files.
Unfortunately, the references to these files will need fixing up in the .kmn file and the .kps files. I see in the Please do make sure your .kmn compiles AND the .kps compiles before recommitting. In the .kpj I can see that there are references to files that are not part of this pull request. The path seems like it's seeing other keyboards. Any other keyboard should not be associated with this keyboard. |
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made the requested changes. Please let me know if there is anything else I need to fix. Thanks!
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
Please delete
|
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
Thanks for the information! We deleted the build folder as well as the 'final' files. Please let us know if there is anything else we need to change. |
Thank you! At the moment we are now waiting for the Keyman 17 build system to be updated on here. At the point we may find a few more changes are needed, but until then we cannot accept any pull requests. We'll get to it as soon as we can. |
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
Delete unnecessary .user file.
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
We're ready to begin doing keyboard review again. Unfortunately, because of the changes to Keyman 17, we are requiring all new keyboards to follow the Keyman 17 conventions.
In addition, there are other changes:
I hope this will be straightforward for you. Thanks for your patience. The good news is once this is done, there are fewer places to maintain some of this information. |
…ard.jpg Rename file to remove space
Remove copyright date and version number.
Add keyboard name to header.
Remove MIT info from copyright.
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
1 similar comment
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
Add version number to .kmn
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
Keyboard currently only supports desktop and web. Not mobile, so I changed `any` to `web desktop`.
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
Necessary changes for the build.
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
1 similar comment
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
Change target back to `any` and add the header statement to include the touch layout.
Add actions to shift state so it will change layers.
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
Add `.js` file back into list of files since I found the mobile layout.
Thank you for your pull request. The Keyman keyboard review team have been notified of your pull request and will review it and build it shortly. |
No description provided.