Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom prop aliases API #171

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

kettanaito
Copy link
Owner

@kettanaito kettanaito commented May 19, 2019

Change log

  • Introduces API that allows to define custom Prop aliases to use with Atomic layout component primitives
  • Abstracts transformNumeric to get rid of circular dependency from Layout

GitHub

Motivation

Having custom prop aliases is something I constantly miss when developing using Atomic layout. Although it may contradict with the original nature of this library being responsible for spacial distribution only, it's the end developer's responsibility to separate concerns. I believe custom prop aliases may help more than they would harm.

Roadmap

  • Implement custom prop aliases API
  • Add necessary tests
  • Update documentation

@coveralls
Copy link

coveralls commented May 19, 2019

Coverage Status

Coverage increased (+6.8%) to 94.715% when pulling 77d8c9a on 126-prop-alias-api into 876765f on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Support prop aliases extensions
2 participants