Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/core plugin #3743

Merged
merged 5 commits into from
May 16, 2024
Merged

Feat/core plugin #3743

merged 5 commits into from
May 16, 2024

Conversation

loicmathieu
Copy link
Member

@loicmathieu loicmathieu commented May 15, 2024 •
edited

  • Add an alias to all plugins to keep the old type working
  • Move all plugins to the new packages under io.kestra.plugin.core

Fixes #2062
Fixes #2863
Fixes #2862
Fixes #3729

@loicmathieu loicmathieu force-pushed the feat/core-plugin branch 3 times, most recently from 4ee136b to eefa2a5 Compare May 15, 2024 13:42
@loicmathieu loicmathieu added the breaking-change Change that requires a migration to a new feature label May 15, 2024
@loicmathieu loicmathieu force-pushed the feat/core-plugin branch 7 times, most recently from a5c02cf to 4f809c8 Compare May 16, 2024 10:18
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@loicmathieu loicmathieu merged commit 17ccfcf into develop May 16, 2024
5 of 6 checks passed
@loicmathieu loicmathieu deleted the feat/core-plugin branch May 16, 2024 11:55
@loicmathieu
Copy link
Member Author

The following package (subgroup) have change, they can be used to mass regex/replace in files:

  • io.kestra.core.models.conditions.types -> io.kestra.plugin.core.condition
  • io.kestra.core.tasks.debugs -> io.kestra.plugin.core.debug
  • io.kestra.core.tasks.executions -> io.kestra.plugin.core.execution
  • io.kestra.core.tasks.flows -> io.kestra.plugin.core.flow
  • io.kestra.core.tasks.log -> io.kestra.plugin.core.log
  • io.kestra.core.tasks.states -> io.kestra.plugin.core.state
  • io.kestra.core.tasks.storages -> io.kestra.plugin.core.storage
  • io.kestra.core.tasks.templating -> io.kestra.plugin.core.templating
  • io.kestra.core.models.triggers.types -> io.kestra.plugin.core.trigger

@loicmathieu
Copy link
Member Author

Some breaking changes:

  • Task default needs to be updated
  • Plugin configuration needs to be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change Change that requires a migration to a new feature
Projects
None yet
Milestone
No milestone
1 participant
@loicmathieu