Update example code in timeseries_dataset.py #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have gone through the example-2 in the TF documentation of keras.utils.timeseries_dataset_from_array. With existing code we can only generate one batch of dataset.In TF forum one of the user raised concern that users may confuse why we are using
input_data = data[:-10]
as it can generate only one batch and there will be loss of data and users may confuse-10
assequence_length
here. Though the intention in the example is to demo on generating batches of data using the API,Its better to useinput_data = data[:]
to avoid confusion and also it give correct demo to generate the total possible no of batches without loss of data.Also I am adding the
sequence_length
as variable in the code to avoid hard coding in the data indexing which will make it better understandable.Thanks!