Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add axis parameter to dice loss #19673

Merged
merged 4 commits into from May 16, 2024
Merged

Add axis parameter to dice loss #19673

merged 4 commits into from May 16, 2024

Conversation

td-jakubl
Copy link
Contributor

Copy link

google-cla bot commented May 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gbaned
Copy link
Collaborator

gbaned commented May 7, 2024

Hi @td-jakubl Can you please sign CLA. Thank you!

@gbaned gbaned requested a review from fchollet May 7, 2024 03:58
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation May 7, 2024
@td-jakubl
Copy link
Contributor Author

Hi @td-jakubl Can you please sign CLA. Thank you!

Done :)

@td-jakubl
Copy link
Contributor Author

Hi @gbaned some test fails and perhaps this is not related to changes in this PR. Do you have any idea why?

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please add a unit test.


Examples:

y_true = tf.constant([[[[1.0], [1.0]], [[0.0], [0.0]]], [[[1.0], [1.0]], [[0.0], [0.0]]]])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a code block for the code example. Do not use TF APIs, only Keras APIs (backend agnostic)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@td-jakubl td-jakubl requested a review from fchollet May 15, 2024 11:27
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution!

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer May 15, 2024
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels May 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.69%. Comparing base (669a97a) to head (2501601).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #19673       +/-   ##
===========================================
- Coverage   81.47%   66.69%   -14.79%     
===========================================
  Files         498      498               
  Lines       45773    45757       -16     
  Branches     8458     8454        -4     
===========================================
- Hits        37294    30517     -6777     
- Misses       6577    13595     +7018     
+ Partials     1902     1645      -257     
Flag Coverage Δ
keras 66.61% <100.00%> (-14.71%) ⬇️
keras-jax ?
keras-numpy 56.29% <100.00%> (-0.16%) ⬇️
keras-tensorflow ?
keras-torch 61.99% <100.00%> (-2.95%) ⬇️
keras.applications ?
keras.applications-jax ?
keras.applications-numpy ?
keras.applications-tensorflow ?
keras.applications-torch ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label May 16, 2024
@td-jakubl
Copy link
Contributor Author

LGTM, thank you for the contribution!

No, problem. I reformated code. Could you rerun workflows?

@fchollet fchollet merged commit 097673f into keras-team:master May 16, 2024
6 checks passed
PR Queue automation moved this from Approved by Reviewer to Merged May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
PR Queue
Merged
Development

Successfully merging this pull request may close these issues.

None yet

5 participants