adding the unittest for wrapped node fetch function and its github action #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sekhar kumar dash <[email protected]>
Signed-off-by: sekhar kumar dash <[email protected]>
Signed-off-by: sekhar kumar dash <[email protected]>
Signed-off-by: sekhar kumar dash <[email protected]>
|
Hi @Sekhar-Kumar-Dash, the problem in commit messages is that a space is missing after ":". |
Signed-off-by: sekhar kumar dash <[email protected]>
Signed-off-by: sekhar kumar dash <[email protected]>
Signed-off-by: sekhar kumar dash <[email protected]>
Signed-off-by: sekhar kumar dash <[email protected]>
Signed-off-by: sekhar kumar dash <[email protected]>
Signed-off-by: sekhar kumar dash <[email protected]>
|
The unit test filename should be of the format ".test.ts" |
Signed-off-by: sekhar kumar dash <[email protected]>
Signed-off-by: sekhar kumar dash <[email protected]>
Signed-off-by: sekhar kumar dash <[email protected]>
Signed-off-by: sekhar kumar dash <[email protected]>
Signed-off-by: sekhar kumar dash <[email protected]>
Signed-off-by: sekhar kumar dash <[email protected]>
Signed-off-by: sekhar kumar dash <[email protected]>
Sekhar-Kumar-Dash
force-pushed
the
master2
branch
from
28e0da8
to
d25cd84
Compare
|
@re-Tick please review the PR |
Signed-off-by: sekhar kumar dash <[email protected]>
|
LGTM. Please add the link in the GSOC readme |
re-Tick
added
Don't Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Info about Issue or bug
Closes: keploy/keploy#354
added a unittest for wrappednodefetch function and added github actions.
note:the unittest is inside the folder so the commit message for this is set as test:adding a folder