Fix sdk records test case in record mode #63
Conversation
|
@re-Tick Can you please review this? @Frey0-0 Please wait while the maintainers review this. After that you can add this in the completed task list in the gsoc repo! |
|
Sure @developer-diganta, can you point me to some other issues in the meantime? Would be really kind of you 🚀 |
tanmay-bajaj
force-pushed
the
fix-test-save
branch
from
d17369f
to
a537aa8
Compare
|
Are there any more changes required on this PR or should I add this in the completed tasks list? @re-Tick |
|
@Frey0-0 please add link to this PR in GSOC/2023 ts-sdk task list corresponding to its issue. |
|
Done! |
developer-diganta
added
Don't Merge
Hey @Frey0-0 ! Congrats on completing this PR! Also, you can try out the other tasks in the task list for typescript sdk or any other project that you would want to contribute to! |
Signed-off-by: Tanmay Bajaj <[email protected]>
… and mode is test Signed-off-by: Tanmay Bajaj <[email protected]>
Signed-off-by: Tanmay Bajaj <[email protected]>
tanmay-bajaj
force-pushed
the
fix-test-save
branch
from
a537aa8
to
072ce3b
Compare
Signed-off-by: Tanmay Bajaj <[email protected]>
Fixes: #430
TS-SDK was saving tests in
testmode also which shouldn't be the case, it should only save tests in therecordmode.I have figured out the correct location to apply the correct if condition.