Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : do not record test-case while in test mode #46

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix : do not record test-case while in test mode #46

wants to merge 2 commits into from

Conversation

shreyanshshah27
Copy link

No description provided.

@re-Tick
Copy link
Contributor

re-Tick commented Mar 1, 2023

Hi @shreyanshshah27, CI is failing due to incorrect commit format. Please follow this format "fix: <COMMIT_MESSAGE>"

@shreyanshshah27
Copy link
Author

Hey @re-Tick I've made the commit name changes.

re-Tick
re-Tick reviewed Mar 2, 2023
View reviewed changes
integrations/express/middleware.ts Outdated
@@ -139,6 +139,9 @@ export function afterMiddleware(keploy: Keploy, req: Request, res: Response) {
return;
}

if (process.env.KEPLOY_MODE=="test") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use MODE_TEST constant intead of "test" here and use "equality without type coersion”.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Contributor

@re-Tick re-Tick Mar 3, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@shreyanshshah27
fix: review comments
7436c5a 
Signed-off-by: Shreyansh Shah <[email protected]>
@re-Tick
Copy link
Contributor

re-Tick commented Mar 3, 2023

Hey @shreyanshshah27, Please add link to this PR in GSOC/2023 Task List.

@shreyanshshah27
Copy link
Author

Hey @re-Tick

I've created a PR, to link this task in GSOC/2023 Task List.

@re-Tick re-Tick added good first issue Good for newcomers Accepted PR is reviewed and Accepted Don't Merge Not to be merged until gsoc results and removed Accepted PR is reviewed and Accepted labels Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@re-Tick re-Tick re-Tick left review comments

Assignees
No one assigned
Labels
Accepted PR is reviewed and Accepted Don't Merge Not to be merged until gsoc results good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@shreyanshshah27 @re-Tick